apr-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "William A. Rowe, Jr." <wr...@covalent.net>
Subject Re: cvs commit: apr/file_io/os2 filestat.c
Date Sat, 29 Dec 2001 00:35:24 GMT
> wrowe       01/12/28 14:28:16
>   Modified:    file_io/os2 filestat.c
>   Log:
>     FS3_to_finfo already assigns the initial valid bits.
>     It makes no sense to define that APR_FINFO_IDENT bits are there, when
>     OS2 can't support them.  Since the APR_INCOMPLETE result is _supposed_
>     to warn the program that some extra action might be required, it is
>     safest to leave those bits unset, and let the program deal with things
>     as it will.

Hint: if this breaks anything, it isn't APR that's broken, it's the caller.

Brian, if you see anything amis, let me know, and I'll track down the
ignorant callers of apr_stat().  It hurts all platforms when we don't watch
for portability concerns with the datum in the file info structure.


View raw message