Return-Path: Delivered-To: apmail-apr-cvs-archive@apr.apache.org Received: (qmail 91218 invoked by uid 500); 8 Nov 2001 21:19:56 -0000 Mailing-List: contact cvs-help@apr.apache.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: Reply-To: dev@apr.apache.org Delivered-To: mailing list cvs@apr.apache.org Received: (qmail 91204 invoked by uid 500); 8 Nov 2001 21:19:56 -0000 Delivered-To: apmail-apr-util-cvs@apache.org Content-Type: text/plain; charset="iso-8859-1" From: Ryan Bloom Reply-To: rbb@covalent.net Organization: Covalent Technologies To: dev@apr.apache.org, jerenkrantz@apache.org, apr-util-cvs@apache.org Subject: Re: cvs commit: apr-util/dbm apr_dbm_berkeleydb.c apr_dbm_gdbm.c apr_dbm_sdbm.c Date: Thu, 8 Nov 2001 13:21:00 -0800 X-Mailer: KMail [version 1.3] References: <20011108194644.83461.qmail@icarus.apache.org> In-Reply-To: <20011108194644.83461.qmail@icarus.apache.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Message-Id: <20011108212100.C06D146DFD@koj.rkbloom.net> X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N On Thursday 08 November 2001 11:46 am, jerenkrantz@apache.org wrote: > jerenkrantz 01/11/08 11:46:44 > > Modified: dbm apr_dbm_berkeleydb.c apr_dbm_gdbm.c apr_dbm_sdbm.c > Log: > We are calling abort(), so we should include stdlib.h. A library should NEVER call abort. If you need to cause the program to die, then you should return a value and let the program handle it cleanly. Dieing inside a library is just wrong. -1 for this change, the correct approach is to remove the abort calls. Ryan ______________________________________________________________ Ryan Bloom rbb@apache.org Covalent Technologies rbb@covalent.net --------------------------------------------------------------