Return-Path: Delivered-To: apmail-apr-cvs-archive@apr.apache.org Received: (qmail 30954 invoked by uid 500); 7 Aug 2001 14:25:20 -0000 Mailing-List: contact cvs-help@apr.apache.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: Reply-To: dev@apr.apache.org Delivered-To: mailing list cvs@apr.apache.org Received: (qmail 30942 invoked from network); 7 Aug 2001 14:25:20 -0000 Date: 7 Aug 2001 14:23:38 -0000 Message-ID: <20010807142338.40836.qmail@icarus.apache.org> From: trawick@apache.org To: apr-cvs@apache.org Subject: cvs commit: apr/file_io/win32 flock.c X-Spam-Rating: h31.sny.collab.net 1.6.2 0/1000/N trawick 01/08/07 07:23:38 Modified: file_io/win32 flock.c Log: add a comment to apr_file_lock() for Win32 about an issue detecting the retry-able condition when another process is holding the lock Revision Changes Path 1.5 +5 -0 apr/file_io/win32/flock.c Index: flock.c =================================================================== RCS file: /home/cvs/apr/file_io/win32/flock.c,v retrieving revision 1.4 retrieving revision 1.5 diff -u -r1.4 -r1.5 --- flock.c 2001/02/16 04:15:39 1.4 +++ flock.c 2001/08/07 14:23:38 1.5 @@ -63,6 +63,11 @@ + (((type & APR_FLOCK_TYPEMASK) == APR_FLOCK_SHARED) ? 0 : LOCKFILE_EXCLUSIVE_LOCK); memset (&offset, 0, sizeof(offset)); + /* XXX on NT 4.0 we get ERROR_LOCK_VIOLATION when we specify + * LOCKFILE_FAIL_IMMEDIATELY and another process is holding + * the lock; something needs to be done so an APR app can + * recognize this as a try-again situation + */ /* Syntax is correct, len is passed for LengthLow and LengthHigh*/ if (!LockFileEx(thefile->filehand, flags, 0, len, len, &offset)) return apr_get_os_error();