apr-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From <...@covalent.net>
Subject Re: cvs commit: apr-util/buckets apr_buckets_mmap.c
Date Tue, 26 Jun 2001 15:20:28 GMT

>   PS: I still question the copying of the mmap data into the pool in
>   pool_setaside()... it seems to me that it's easy for that to accidentally
>   copy a very large file in its entirety into memory.  What am I missing?

Your right, this can do that.  However, we really can't keep that from
happening.  In reality, the mmap_setaside function should just map it back
to a file opened out of the new pool.

Ryan

_____________________________________________________________________________
Ryan Bloom                        	rbb@apache.org
Covalent Technologies			rbb@covalent.net
-----------------------------------------------------------------------------


Mime
View raw message