apr-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ben Laurie <...@algroup.co.uk>
Subject Re: cvs commit: apr/locks/unix locks.c
Date Tue, 05 Jun 2001 18:23:22 GMT
Isn't this another example where we should just die instead of returning
an error?

Cheers,

Ben.

dreid@apache.org wrote:
> 
> dreid       01/06/05 06:48:28
> 
>   Modified:    locks/unix locks.c
>   Log:
>   One slipped through the rename, but got it now!
> 
>   Revision  Changes    Path
>   1.50      +1 -1      apr/locks/unix/locks.c
> 
>   Index: locks.c
>   ===================================================================
>   RCS file: /home/cvs/apr/locks/unix/locks.c,v
>   retrieving revision 1.49
>   retrieving revision 1.50
>   diff -u -r1.49 -r1.50
>   --- locks.c   2001/06/05 13:22:45     1.49
>   +++ locks.c   2001/06/05 13:48:25     1.50
>   @@ -324,7 +324,7 @@
>    apr_status_t apr_os_lock_put(apr_lock_t **lock, apr_os_lock_t *thelock,
>                               apr_pool_t *pool)
>    {
>   -    if (cont == NULL) {
>   +    if (pool == NULL) {
>            return APR_ENOPOOL;
>        }
>        if ((*lock) == NULL) {
> 
> 
> 

--
http://www.apache-ssl.org/ben.html

"There is no limit to what a man can do or how far he can go if he
doesn't mind who gets the credit." - Robert Woodruff

Mime
View raw message