apr-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jwool...@apache.org
Subject cvs commit: apr-util/include apr_buckets.h
Date Wed, 13 Jun 2001 19:16:42 GMT
jwoolley    01/06/13 12:16:40

  Modified:    buckets  apr_buckets.c apr_buckets_eos.c apr_buckets_flush.c
                        apr_buckets_pipe.c apr_buckets_simple.c
                        apr_buckets_socket.c
               include  apr_buckets.h
  Log:
  Rename apr_bucket_destroy_notimpl() => apr_bucket_destroy_noop()
  to match the true intent of the bucket types that need it and to
  match apr_bucket_setaside_noop().  Essentially, destruction is a
  required function.  The function might not do anything, but that's
  only allowed if the bucket type truly doesn't have any private
  resources that it needs to free.
  
  Revision  Changes    Path
  1.51      +1 -1      apr-util/buckets/apr_buckets.c
  
  Index: apr_buckets.c
  ===================================================================
  RCS file: /home/cvs/apr-util/buckets/apr_buckets.c,v
  retrieving revision 1.50
  retrieving revision 1.51
  diff -u -d -u -r1.50 -r1.51
  --- apr_buckets.c	2001/06/07 10:13:33	1.50
  +++ apr_buckets.c	2001/06/13 19:16:05	1.51
  @@ -78,7 +78,7 @@
       return APR_ENOTIMPL;
   }
   
  -APU_DECLARE_NONSTD(void) apr_bucket_destroy_notimpl(void *data)
  +APU_DECLARE_NONSTD(void) apr_bucket_destroy_noop(void *data)
   {
       return;
   }
  
  
  
  1.25      +1 -1      apr-util/buckets/apr_buckets_eos.c
  
  Index: apr_buckets_eos.c
  ===================================================================
  RCS file: /home/cvs/apr-util/buckets/apr_buckets_eos.c,v
  retrieving revision 1.24
  retrieving revision 1.25
  diff -u -d -u -r1.24 -r1.25
  --- apr_buckets_eos.c	2001/06/07 10:13:34	1.24
  +++ apr_buckets_eos.c	2001/06/13 19:16:07	1.25
  @@ -89,7 +89,7 @@
   
   APU_DECLARE_DATA const apr_bucket_type_t apr_bucket_type_eos = {
       "EOS", 5,
  -    apr_bucket_destroy_notimpl,
  +    apr_bucket_destroy_noop,
       eos_read,
       apr_bucket_setaside_noop,
       apr_bucket_split_notimpl,
  
  
  
  1.17      +1 -1      apr-util/buckets/apr_buckets_flush.c
  
  Index: apr_buckets_flush.c
  ===================================================================
  RCS file: /home/cvs/apr-util/buckets/apr_buckets_flush.c,v
  retrieving revision 1.16
  retrieving revision 1.17
  diff -u -d -u -r1.16 -r1.17
  --- apr_buckets_flush.c	2001/06/07 10:13:35	1.16
  +++ apr_buckets_flush.c	2001/06/13 19:16:11	1.17
  @@ -89,7 +89,7 @@
   
   APU_DECLARE_DATA const apr_bucket_type_t apr_bucket_type_flush = {
       "FLUSH", 5,
  -    apr_bucket_destroy_notimpl,
  +    apr_bucket_destroy_noop,
       flush_read,
       apr_bucket_setaside_noop,
       apr_bucket_split_notimpl,
  
  
  
  1.35      +1 -1      apr-util/buckets/apr_buckets_pipe.c
  
  Index: apr_buckets_pipe.c
  ===================================================================
  RCS file: /home/cvs/apr-util/buckets/apr_buckets_pipe.c,v
  retrieving revision 1.34
  retrieving revision 1.35
  diff -u -d -u -r1.34 -r1.35
  --- apr_buckets_pipe.c	2001/04/11 19:07:05	1.34
  +++ apr_buckets_pipe.c	2001/06/13 19:16:13	1.35
  @@ -152,7 +152,7 @@
   
   APU_DECLARE_DATA const apr_bucket_type_t apr_bucket_type_pipe = {
       "PIPE", 5,
  -    apr_bucket_destroy_notimpl,
  +    apr_bucket_destroy_noop,
       pipe_read,
       apr_bucket_setaside_notimpl,
       apr_bucket_split_notimpl,
  
  
  
  1.28      +2 -2      apr-util/buckets/apr_buckets_simple.c
  
  Index: apr_buckets_simple.c
  ===================================================================
  RCS file: /home/cvs/apr-util/buckets/apr_buckets_simple.c,v
  retrieving revision 1.27
  retrieving revision 1.28
  diff -u -d -u -r1.27 -r1.28
  --- apr_buckets_simple.c	2001/06/07 10:13:37	1.27
  +++ apr_buckets_simple.c	2001/06/13 19:16:15	1.28
  @@ -157,7 +157,7 @@
   
   const apr_bucket_type_t apr_bucket_type_immortal = {
       "IMMORTAL", 5,
  -    apr_bucket_destroy_notimpl,
  +    apr_bucket_destroy_noop,
       simple_read,
       apr_bucket_setaside_noop,
       apr_bucket_simple_split,
  @@ -166,7 +166,7 @@
   
   APU_DECLARE_DATA const apr_bucket_type_t apr_bucket_type_transient = {
       "TRANSIENT", 5,
  -    apr_bucket_destroy_notimpl, 
  +    apr_bucket_destroy_noop, 
       simple_read,
       transient_setaside,
       apr_bucket_simple_split,
  
  
  
  1.24      +1 -1      apr-util/buckets/apr_buckets_socket.c
  
  Index: apr_buckets_socket.c
  ===================================================================
  RCS file: /home/cvs/apr-util/buckets/apr_buckets_socket.c,v
  retrieving revision 1.23
  retrieving revision 1.24
  diff -u -d -u -r1.23 -r1.24
  --- apr_buckets_socket.c	2001/04/11 19:07:06	1.23
  +++ apr_buckets_socket.c	2001/06/13 19:16:17	1.24
  @@ -147,7 +147,7 @@
   
   APU_DECLARE_DATA const apr_bucket_type_t apr_bucket_type_socket = {
       "SOCKET", 5,
  -    apr_bucket_destroy_notimpl,
  +    apr_bucket_destroy_noop,
       socket_read,
       apr_bucket_setaside_notimpl, 
       apr_bucket_split_notimpl,
  
  
  
  1.99      +15 -5     apr-util/include/apr_buckets.h
  
  Index: apr_buckets.h
  ===================================================================
  RCS file: /home/cvs/apr-util/include/apr_buckets.h,v
  retrieving revision 1.98
  retrieving revision 1.99
  diff -u -d -u -r1.98 -r1.99
  --- apr_buckets.h	2001/06/13 16:48:46	1.98
  +++ apr_buckets.h	2001/06/13 19:16:35	1.99
  @@ -877,12 +877,22 @@
                          apr_bucket_copy_notimpl(apr_bucket *e, apr_bucket **c);
   
   /**
  - * A place holder function that signifies that the destroy function was not
  - * implemented for this bucket
  - * @param data The bucket to destroy
  - * @deffunc void apr_bucket_destroy_notimpl(void *data)
  + * A place holder function that signifies that this bucket does not need
  + * to do anything special to be destroyed.  That's only the case for buckets
  + * that either have no data (metadata buckets) or buckets whose data pointer
  + * points to something that's not a bucket-type-specific structure, as with
  + * simple buckets where data points to a string and pipe buckets where data
  + * points directly to the apr_file_t.
  + * @param data The bucket data to destroy
  + * @deffunc void apr_bucket_destroy_noop(void *data)
    */ 
  -APU_DECLARE_NONSTD(void) apr_bucket_destroy_notimpl(void *data);
  +APU_DECLARE_NONSTD(void) apr_bucket_destroy_noop(void *data);
  +
  +/**
  + * There is no apr_bucket_destroy_notimpl, because destruction is required
  + * to be implemented (it could be a noop, but only if that makes sense for
  + * the bucket type)
  + */
   
   /* There is no apr_bucket_read_notimpl, because it is a required function
    */
  
  
  

Mime
View raw message