Return-Path: Delivered-To: apmail-apr-cvs-archive@apr.apache.org Received: (qmail 84948 invoked by uid 500); 28 Feb 2001 11:41:25 -0000 Mailing-List: contact cvs-help@apr.apache.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: Reply-To: dev@apr.apache.org Delivered-To: mailing list cvs@apr.apache.org Received: (qmail 84683 invoked by uid 500); 28 Feb 2001 11:41:22 -0000 Delivered-To: apmail-apr-util-cvs@apache.org Message-ID: <3A9CE3A5.D1094479@algroup.co.uk> Date: Wed, 28 Feb 2001 11:40:21 +0000 From: Ben Laurie X-Mailer: Mozilla 4.76 [en] (Windows NT 5.0; U) X-Accept-Language: en MIME-Version: 1.0 To: dev@apr.apache.org CC: apr-util-cvs@apache.org Subject: Re: cvs commit: apr-util/buckets apr_buckets_simple.c References: <20010228021902.50664.qmail@apache.org> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Spam-Rating: h31.sny.collab.net 1.6.2 0/1000/N trawick@apache.org wrote: > > trawick 01/02/27 18:19:02 > > Modified: buckets apr_buckets_simple.c > Log: > Fix some warnings related to the fact that you can't do arithmetic > with a void *. Wouldn't it be better to make b->data a char * in the first place? Cheers, Ben. > > Revision Changes Path > 1.24 +2 -2 apr-util/buckets/apr_buckets_simple.c > > Index: apr_buckets_simple.c > =================================================================== > RCS file: /home/cvs/apr-util/buckets/apr_buckets_simple.c,v > retrieving revision 1.23 > retrieving revision 1.24 > diff -u -r1.23 -r1.24 > --- apr_buckets_simple.c 2001/02/27 20:45:36 1.23 > +++ apr_buckets_simple.c 2001/02/28 02:19:02 1.24 > @@ -93,7 +93,7 @@ > static apr_status_t simple_read(apr_bucket *b, const char **str, > apr_size_t *len, apr_read_type_e block) > { > - *str = b->data + b->start; > + *str = (char *)b->data + b->start; > *len = b->length; > return APR_SUCCESS; > } > @@ -126,7 +126,7 @@ > */ > static apr_status_t transient_setaside(apr_bucket *b) > { > - b = apr_bucket_heap_make(b, b->data+b->start, b->length, 1, NULL); > + b = apr_bucket_heap_make(b, (char *)b->data + b->start, b->length, 1, NULL); > if (b == NULL) { > return APR_ENOMEM; > } > > > -- http://www.apache-ssl.org/ben.html "There is no limit to what a man can do or how far he can go if he doesn't mind who gets the credit." - Robert Woodruff ApacheCon 2001! http://ApacheCon.com/