Return-Path: Mailing-List: contact cvs-help@apr.apache.org; run by ezmlm Delivered-To: mailing list cvs@apr.apache.org Received: (qmail 85504 invoked from network); 19 Jan 2001 14:43:45 -0000 Received: from 3ff8faf3.dsl.flashcom.net (HELO koj.covalent.net) (63.248.250.243) by h31.sny.collab.net with SMTP; 19 Jan 2001 14:43:45 -0000 Received: from rbb (helo=localhost) by koj.covalent.net with local-esmtp (Exim 3.16 #1) id 14JcpN-0003Sk-00; Fri, 19 Jan 2001 06:47:45 -0800 Date: Fri, 19 Jan 2001 06:47:45 -0800 (PST) From: rbb@covalent.net X-Sender: rbb@koj To: dev@apr.apache.org cc: apr-cvs@apache.org Subject: Re: cvs commit: apr/dso/win32 dso.c In-Reply-To: <20010119095632.76759.qmail@apache.org> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Spam-Rating: h31.sny.collab.net 1.6.2 0/1000/N > watch out for a double-unload. one manually from apr_dso_unload(), followed > by one through the pool cleanup. > 1) protect the unload by setting/checking the handle to NULL > 2) unload "runs" the cleanup to also remove it from the pool cleanup > dllhandle *handle; /* Handle to the DSO loaded */ > int failing_errno; /* Don't save the buffer returned by > strerror(); it gets reused */ > + apr_pool_t *pool; This really belongs at the top of the structure to keep the format the same for all APR types. Ryan _______________________________________________________________________________ Ryan Bloom rbb@apache.org 406 29th St. San Francisco, CA 94131 -------------------------------------------------------------------------------