Return-Path: Mailing-List: contact cvs-help@apr.apache.org; run by ezmlm Delivered-To: mailing list cvs@apr.apache.org Received: (qmail 62990 invoked from network); 16 Dec 2000 15:01:58 -0000 Received: from 3ff8faf3.dsl.flashcom.net (HELO koj.covalent.net) (63.248.250.243) by locus.apache.org with SMTP; 16 Dec 2000 15:01:58 -0000 Received: from rbb (helo=localhost) by koj.covalent.net with local-esmtp (Exim 3.16 #1) id 147Iss-0001KZ-00; Sat, 16 Dec 2000 07:04:26 -0800 Date: Sat, 16 Dec 2000 07:04:26 -0800 (PST) From: rbb@covalent.net X-Sender: rbb@koj.rkbloom.net To: dev@apr.apache.org cc: apr-cvs@apache.org Subject: Re: cvs commit: apr STATUS In-Reply-To: <20001214111036.54641.qmail@locus.apache.org> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Spam-Rating: locus.apache.org 1.6.2 0/1000/N > + * apr_create_lock() changes: > + - It ignores the "type" parameter, so toss it. > + - The fname param is allowed to be NULL on the Unix platform. > + Change it to always use the passed value, and check callers. These are in there by design. The type parameter didn't used to be there, but we have added it for the future. At some point, somebody is going to get the time to add read/write locks as well as the mutex's that we currently have. At that time, the type is required. Having the filename be optional on some platforms is also valid. There is no reason to force people who are only building on platforms that don't need a file to have a file name there. I have used that feature in some projects, because I knew my target platforms. Ryan _______________________________________________________________________________ Ryan Bloom rbb@apache.org 406 29th St. San Francisco, CA 94131 -------------------------------------------------------------------------------