apr-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Sam TH <...@uchicago.edu>
Subject Re: cvs commit: apr/include apr_lib.h
Date Sun, 03 Dec 2000 13:42:55 GMT
On Sun, Dec 03, 2000 at 10:11:43AM -0000, gstein@locus.apache.org wrote:
> gstein      00/12/03 02:11:43
> 
>   Modified:    include  apr_lib.h
>   Log:
>   isascii() is not available on PowerPC versions of BeOS. Supply a definition.

This still doesn't work.  It turns out that neither BEOS nor
__POWER_PC__ is defined at the point in Subversion that this gets used
and likely not in other APR-using apps either.  So, new patch, using
HAVE_isascii, which doesn't require including apr_private.h, despite
Ryan's worry.  Also, defining it before using it is helpful. :-)

Index: apr_lib.h
===================================================================
RCS file: /home/cvspublic/apr/include/apr_lib.h,v
retrieving revision 1.45
diff -u -r1.45 apr_lib.h
--- apr_lib.h	2000/12/03 10:11:43	1.45
+++ apr_lib.h	2000/12/03 13:41:59
@@ -107,6 +107,11 @@
  * that's legacy libc for ya.  These new macros do not support EOF like
  * the standard macros do.  Tough.
  */
+
+#if !HAVE_isascii
+#define isascii(c) (((c) & ~0x7f)==0)
+#endif
+
 #define apr_isalnum(c) (isalnum(((unsigned char)(c))))
 #define apr_isalpha(c) (isalpha(((unsigned char)(c))))
 #define apr_iscntrl(c) (iscntrl(((unsigned char)(c))))
@@ -121,10 +126,6 @@
 #define apr_isxdigit(c) (isxdigit(((unsigned char)(c))))
 #define apr_tolower(c) (tolower(((unsigned char)(c))))
 #define apr_toupper(c) (toupper(((unsigned char)(c))))
-
-#if BEOS && __POWER_PC__
-#define isascii(c) (((c) & ~0x7f)==0)
-#endif
 
 /*
  * Small utility macros to make things easier to read.  Not usually a

           
	sam th		     
	sam@uchicago.edu
	http://www.abisource.com/~sam/
	GnuPG Key:  
	http://www.abisource.com/~sam/key

Mime
View raw message