apr-bugs mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject [Bug 59582] New: poll/unix/z_asio.c:271]: (style) Suspicious condition
Date Thu, 19 May 2016 16:31:27 GMT
https://bz.apache.org/bugzilla/show_bug.cgi?id=59582

            Bug ID: 59582
           Summary: poll/unix/z_asio.c:271]: (style) Suspicious condition
           Product: APR
           Version: HEAD
          Hardware: PC
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: APR
          Assignee: bugs@apr.apache.org
          Reporter: dcb314@hotmail.com

poll/unix/z_asio.c:271]: (style) Suspicious condition (assignment +
comparison); Clarify expression with parentheses.

Source code is

        if (rv = apr_thread_mutex_create(&(priv->ring_lock),
                                           APR_THREAD_MUTEX_DEFAULT,
                                           p) != APR_SUCCESS) {

Maybe better code

        if ((rv = apr_thread_mutex_create(&(priv->ring_lock),
                                           APR_THREAD_MUTEX_DEFAULT,
                                           p)) != APR_SUCCESS) {

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@apr.apache.org
For additional commands, e-mail: bugs-help@apr.apache.org


Mime
View raw message