apr-bugs mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject [Bug 59057] APR_VERSION_STRING_CSV from apr_version.h is malformed and fails compilation with some compilers
Date Wed, 24 Feb 2016 02:49:35 GMT
https://bz.apache.org/bugzilla/show_bug.cgi?id=59057

vitaly.krugl.web@gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 OS|                            |All

--- Comment #3 from vitaly.krugl.web@gmail.com ---
Ignore my earlier comment about "It should have been defined similarly to
APR_VERSION_STRING (using APR_STRINGIFY and quotes around punctuation), but
with commas instead of periods."

I see what's going on here, and it's a catch-22 situation given how the *OLDER*
apr_version.h and libapr.rc were implemented:


First, apr_version.h in apr v1.5.1 contains a definition considered malformed
by the gcc toolchain (mingwpy in particular):

#define APR_VERSION_STRING_CSV APR_MAJOR_VERSION ##, \
                               ##APR_MINOR_VERSION ##, \
                               ##APR_PATCH_VERSION

So, the gcc compiler chokes on it. this was intended to produce the equivalent
of

#define APR_VERSION_STRING_CSV 1,5,1

which libapr.rc relies on here:

FILEVERSION APR_VERSION_STRING_CSV,0
PRODUCTVERSION APR_VERSION_STRING_CSV,0




The ones in HEAD should be okay, though, since APR_VERSION_STRING_CSV has been
redefined as the following, which passes the mingwpy build:

#define APR_VERSION_STRING_CSV APR_MAJOR_VERSION, \
                               APR_MINOR_VERSION, \
                               APR_PATCH_VERSION

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@apr.apache.org
For additional commands, e-mail: bugs-help@apr.apache.org


Mime
View raw message