apr-bugs mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject [Bug 58123] apr_proc_create does not quote APR_SHELLCMD argument strings correctly on Unix
Date Sat, 11 Jul 2015 04:00:25 GMT
https://bz.apache.org/bugzilla/show_bug.cgi?id=58123

jared.breeden@gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jared.breeden@gmail.com

--- Comment #2 from jared.breeden@gmail.com ---
Created attachment 32895
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=32895&action=edit
Proposed patch

Here is a proposed patch to the proc file. It's basically taking the same code
from the win32/proc.c file. `has_space` is duplicated, which is probably not
ideal. However, it was tiny and static so it seemed ok. I can refactor to
remove the dup if desired. Just let me know where to put it!

Ran `testall` before & after the patch. Same results each time (2 failures on
my system, neither with procs) shown below. This fixes `apr_proc_create` for my
use case.

[jared:~/projects/apr/test] ./testall
testatomic          : SUCCESS
testdir             : SUCCESS
testdso             : SUCCESS
testdup             : SUCCESS
testenv             : SUCCESS
testescape          : SUCCESS
testfile            : SUCCESS
testfilecopy        : SUCCESS
testfileinfo        : SUCCESS
testflock           : SUCCESS
testfmt             : SUCCESS
testfnmatch         : SUCCESS
testargs            : SUCCESS
testhash            : SUCCESS
testhooks           : SUCCESS
testipsub           : SUCCESS
testlock            : SUCCESS
testcond            : SUCCESS
testlfs             : SUCCESS
testmmap            : SUCCESS
testnames           : SUCCESS
testoc              : SUCCESS
testpath            : SUCCESS
testpipe            : SUCCESS
testpoll            : FAILED 1 of 24
testpools           : SUCCESS
testproc            : SUCCESS
testprocmutex       : \default_timedlock() not implemented,-flock_timedlock()
not implemented,|sysvsem_timedlock() not implemented,\posix_timedlock() not
implemented,-fcntl_timedlock() not implemented,-default_timed not
implemented,FAILED 1 of 6
testrand            : SUCCESS
testsleep           : SUCCESS
testshm             : SUCCESS
testsock            : SUCCESS
testsockets         : SUCCESS
testsockopt         : SUCCESS
teststr             : SUCCESS
teststrnatcmp       : SUCCESS
testtable           : SUCCESS
testtemp            : SUCCESS
testthread          : SUCCESS
testtime            : SUCCESS
testud              : SUCCESS
testuser            : SUCCESS
testvsn             : SUCCESS
teststrmatch        : SUCCESS
testuri             : SUCCESS
testuuid            : SUCCESS
testbuckets         : SUCCESS
testpass            : SUCCESS
testbase64          : SUCCESS
testmd4             : SUCCESS
testmd5             : SUCCESS
testcrypto          : SUCCESS
testdbd             : SUCCESS
testdate            : SUCCESS
testmemcache        : SUCCESS
testxml             : SUCCESS
testxlate           : SUCCESS
testrmm             : SUCCESS
testdbm             : SUCCESS
testqueue           : SUCCESS
testreslist         : SUCCESS
testlfsabi          : SUCCESS
testskiplist        : SUCCESS
Failed Tests           Total    Fail    Failed %
===================================================
testpoll                  24       1      4.17%
testprocmutex              6       1     16.67%

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@apr.apache.org
For additional commands, e-mail: bugs-help@apr.apache.org


Mime
View raw message