Return-Path: X-Original-To: apmail-apr-bugs-archive@www.apache.org Delivered-To: apmail-apr-bugs-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 6012C10E7A for ; Tue, 18 Jun 2013 18:45:45 +0000 (UTC) Received: (qmail 64715 invoked by uid 500); 18 Jun 2013 18:45:45 -0000 Delivered-To: apmail-apr-bugs-archive@apr.apache.org Received: (qmail 64674 invoked by uid 500); 18 Jun 2013 18:45:44 -0000 Mailing-List: contact bugs-help@apr.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@apr.apache.org Delivered-To: mailing list bugs@apr.apache.org Received: (qmail 64666 invoked by uid 99); 18 Jun 2013 18:45:44 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 18 Jun 2013 18:45:44 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.115] (HELO eir.zones.apache.org) (140.211.11.115) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 18 Jun 2013 18:45:43 +0000 Received: by eir.zones.apache.org (Postfix, from userid 80) id 6A06D1B906; Tue, 18 Jun 2013 18:45:23 +0000 (UTC) From: bugzilla@apache.org To: bugs@apr.apache.org Subject: [Bug 55115] New: Bucket insert macros have mismatch between comments and code Date: Tue, 18 Jun 2013 18:45:22 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: APR X-Bugzilla-Component: APR X-Bugzilla-Version: HEAD X-Bugzilla-Keywords: X-Bugzilla-Severity: trivial X-Bugzilla-Who: mike.rumph@oracle.com X-Bugzilla-Status: NEW X-Bugzilla-Priority: P2 X-Bugzilla-Assigned-To: bugs@apr.apache.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter attachments.created Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: https://issues.apache.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-Virus-Checked: Checked by ClamAV on apache.org https://issues.apache.org/bugzilla/show_bug.cgi?id=55115 Bug ID: 55115 Summary: Bucket insert macros have mismatch between comments and code Product: APR Version: HEAD Hardware: All OS: All Status: NEW Severity: trivial Priority: P2 Component: APR Assignee: bugs@apr.apache.org Reporter: mike.rumph@oracle.com Created attachment 30459 --> https://issues.apache.org/bugzilla/attachment.cgi?id=30459&action=edit Rewords the comments for bucket insert macros. In the apr_buckets.h header the following macros have a mismatch between the comments and the implementation: APR_BRIGADE_INSERT_HEAD, APR_BRIGADE_INSERT_TAIL, APR_BUCKET_INSERT_BEFORE and APR_BUCKET_INSERT_AFTER The comments for each of these macros mention inserting a list of buckets into a brigade. But the implementation in each case invokes an APR_RING_INSERT_* macro which inserts a single element (not a list of elements). If it were truly the intent to insert a list of buckets, some form of APR_RING_SPLICE_* macros would be used. I have attached a patch for rewording the comments from inserting a list to inserting a single bucket. If the comments were taken at face value and a list insert was attempted, the specified bucket would be correctly added to the brigade, but the remaining list would be mangled. -- You are receiving this mail because: You are the assignee for the bug. --------------------------------------------------------------------- To unsubscribe, e-mail: bugs-unsubscribe@apr.apache.org For additional commands, e-mail: bugs-help@apr.apache.org