apr-bugs mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject [Bug 55115] New: Bucket insert macros have mismatch between comments and code
Date Tue, 18 Jun 2013 18:45:22 GMT
https://issues.apache.org/bugzilla/show_bug.cgi?id=55115

            Bug ID: 55115
           Summary: Bucket insert macros have mismatch between comments
                    and code
           Product: APR
           Version: HEAD
          Hardware: All
                OS: All
            Status: NEW
          Severity: trivial
          Priority: P2
         Component: APR
          Assignee: bugs@apr.apache.org
          Reporter: mike.rumph@oracle.com

Created attachment 30459
  --> https://issues.apache.org/bugzilla/attachment.cgi?id=30459&action=edit
Rewords the comments for bucket insert macros.

In the apr_buckets.h header the following macros have a mismatch between the
comments and the implementation:
APR_BRIGADE_INSERT_HEAD, APR_BRIGADE_INSERT_TAIL, APR_BUCKET_INSERT_BEFORE and
APR_BUCKET_INSERT_AFTER

The comments for each of these macros mention inserting a list of buckets into
a brigade.  But the implementation in each case invokes an APR_RING_INSERT_*
macro which inserts a single element (not a list of elements). If it were truly
the intent to insert a list of buckets, some form of APR_RING_SPLICE_* macros
would be used.

I have attached a patch for rewording the comments from inserting a list to
inserting a single bucket.

If the comments were taken at face value and a list insert was attempted, the
specified bucket would be correctly added to the brigade, but the remaining
list would be mangled.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@apr.apache.org
For additional commands, e-mail: bugs-help@apr.apache.org


Mime
View raw message