Return-Path: X-Original-To: apmail-apr-bugs-archive@www.apache.org Delivered-To: apmail-apr-bugs-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 538FE7E0C for ; Sat, 17 Dec 2011 07:14:58 +0000 (UTC) Received: (qmail 55412 invoked by uid 500); 17 Dec 2011 07:14:57 -0000 Delivered-To: apmail-apr-bugs-archive@apr.apache.org Received: (qmail 55381 invoked by uid 500); 17 Dec 2011 07:14:55 -0000 Mailing-List: contact bugs-help@apr.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@apr.apache.org Delivered-To: mailing list bugs@apr.apache.org Received: (qmail 55373 invoked by uid 99); 17 Dec 2011 07:14:52 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 17 Dec 2011 07:14:52 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.115] (HELO eir.zones.apache.org) (140.211.11.115) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 17 Dec 2011 07:14:51 +0000 Received: by eir.zones.apache.org (Postfix, from userid 80) id 197DC3C273; Sat, 17 Dec 2011 07:14:30 +0000 (UTC) From: bugzilla@apache.org To: bugs@apr.apache.org Subject: DO NOT REPLY [Bug 52350] New: Code clean up (apr_strings.c) Date: Sat, 17 Dec 2011 07:14:29 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: APR X-Bugzilla-Component: APR X-Bugzilla-Keywords: X-Bugzilla-Severity: enhancement X-Bugzilla-Who: christophe.jaillet@wanadoo.fr X-Bugzilla-Status: NEW X-Bugzilla-Priority: P2 X-Bugzilla-Assigned-To: bugs@apr.apache.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Changed-Fields: Message-ID: X-Bugzilla-URL: https://issues.apache.org/bugzilla/ Auto-Submitted: auto-generated Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 https://issues.apache.org/bugzilla/show_bug.cgi?id=52350 Bug #: 52350 Summary: Code clean up (apr_strings.c) Product: APR Version: HEAD Platform: PC OS/Version: Windows 2000 Status: NEW Severity: enhancement Priority: P2 Component: APR AssignedTo: bugs@apr.apache.org ReportedBy: christophe.jaillet@wanadoo.fr Classification: Unclassified Created attachment 28081 --> https://issues.apache.org/bugzilla/attachment.cgi?id=28081 Proposed patch Hi, in strings/apr_strings.c, most functions allocate its own memory when needed except 'apr_pstrdup' which actually call 'apr_pmemdup' for that. This patch inlines this call in order to be more consistent with-in the code. This also removes a small calling overhead in case the compiler does not inline the function by itself. Hoping this helps. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. --------------------------------------------------------------------- To unsubscribe, e-mail: bugs-unsubscribe@apr.apache.org For additional commands, e-mail: bugs-help@apr.apache.org