apr-bugs mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 50334] APR_RESTORE_THE_ENVIRONMENT clobbers CPPFLAGS, LDFLAGS, LIBS, CFLAGS, INCLUDES when set to a single space
Date Wed, 21 Sep 2011 00:22:24 GMT
https://issues.apache.org/bugzilla/show_bug.cgi?id=50334

Nathan Phillip Brink (binki) <binki@gentoo.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #27545|0                           |1
        is obsolete|                            |

--- Comment #11 from Nathan Phillip Brink (binki) <binki@gentoo.org> 2011-09-21 00:22:24
UTC ---
Comment on attachment 27545
  --> https://issues.apache.org/bugzilla/attachment.cgi?id=27545
alternate patch to preserve the space

This patch fixes this particular bug but does not solve the root problem.
./configure need to treat the user's CPPFLAGS value as a string potentially
containing any number of any sorts of characters in it.

- The user may use the '%' character in CPPFLAGS, changing the action of the
sed expression.

- The user may use BRE metacharacters, such as `.', `*', `[', or `\', in
CPPFLAGS. sed's s command is not a strict string find-and-replace mechanism, it
first matches BREs.

Of course, I cannot think of an obvious reason for the user to do any of these
things. But leaving ./configure _this_ obviously sensitive to the contents of
any of the *FLAGS seems to be asking for further trouble similar in nature to
this bug.

My patch, on the other hand, follows POSIX shell rules and it handles any
string... though I still use sed which feels like overkill for this...

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@apr.apache.org
For additional commands, e-mail: bugs-help@apr.apache.org


Mime
View raw message