apr-bugs mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 46175] Full Mingw+MSys support
Date Tue, 02 Jun 2009 02:41:52 GMT
https://issues.apache.org/bugzilla/show_bug.cgi?id=46175





--- Comment #2 from Will Rowe <wrowe@apache.org>  2009-06-01 19:41:49 PST ---
Sorry for not responding earlier.

This patch is frozen, primarily due to the number of unintended consequences
introduced by modification of apr.h.in across a broad number of platforms,
and the fact that the vast majority of changes to apr.h.in are not required
for the external consumers, nor the public interface.

Thus far; the tlhelp32.h should never have been included, and this has been
added for both to include/arch/win32/apr_arch_misc.h and removed from apr.hw.

Similarly other things should be clarified, and apr.h.in treated as the
reference
file to *avoid* changing.  Other mistakes in the patch, such as;

 /* Mechanisms to properly type numeric literals */
+#ifdef _MSC_VER
+#define APR_INT64_C(val) (val##i64)
+#define APR_UINT64_C(val) (val##Ui64)
+#else
 @int64_literal@
 @uint64_literal@
+#endif

should have been corrected by adjusting [u]int64_literal definitions within
the autoconf script.

So this patch is in need of further explanation and clarification and
absolutely
cannot be applied as-is to the stable shipping branch.

I'll try to piece through it, but in the future, consider submitting a number
of smaller single-function patches, so that the ones which are correct can be
applied immediately, while the ones which are incorrect can be clarified and
discussed.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@apr.apache.org
For additional commands, e-mail: bugs-help@apr.apache.org


Mime
View raw message