apr-bugs mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 46425] Apr should set FD_CLOEXEC if APR_FOPEN_NOCLEANUP is not set
Date Mon, 23 Feb 2009 20:16:16 GMT

--- Comment #16 from Stefan Fritsch <sf@sfritsch.de>  2009-02-23 12:16:15 PST ---
(In reply to comment #12)
> apr_socket_create in your patch sets CLOEXEC via fcntl even if SOCK_CLOEXEC was
> used. Looks like missing #ifndef SOCK_CLOEXEC, right?
> btw. probably these things need configure checks since for example SOCK_CLOEXEC
> is supported since 2.6.27 but I already have few users that run older kernels
> (.25) and have newer glibc that actually defines SOCK_CLOEXEC. The bad thing
> with this flag is that socket() fails on older kernels and is not ignored.

I assumed that SOCK_CLOEXEC behaved like O_CLOEXEC. But if it is not ignored
then there is no reason for the additional fcntl calls. A configure check would
be good in this case.

Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

To unsubscribe, e-mail: bugs-unsubscribe@apr.apache.org
For additional commands, e-mail: bugs-help@apr.apache.org

View raw message