apr-bugs mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 46425] Apr should set FD_CLOEXEC if APR_FOPEN_NOCLEANUP is not set
Date Mon, 23 Feb 2009 20:12:50 GMT
https://issues.apache.org/bugzilla/show_bug.cgi?id=46425





--- Comment #15 from Stefan Fritsch <sf@sfritsch.de>  2009-02-23 12:12:48 PST ---
(In reply to comment #13)
> Pretty sure removing the custom inherit_unset function is a mistake. It is
> about buffer flushing there - not closing the file. Also, replacing cleanup
> functions with null functions is an error - same reason.

The problem was that the normal cleanup did flush the buffers. I only removed
the child cleanup, because close by FD_CLOEXEC does the right thing in this
case.

(In reply to comment #14)
> In addition, there is the question of unlinking the file (if required) and
> removing the mutex. We can't just not have that, I think.

Unlinking the file is not done in the child cleanup (is_child == 0), but you
are right about the mutex. I missed that and will post an updated patch. There
is also a typo in port.c.

For all other child cleanups than apr_unix_file_child_cleanup, it is ok to
remove them because they only close the fd anyway.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@apr.apache.org
For additional commands, e-mail: bugs-help@apr.apache.org


Mime
View raw message