apr-bugs mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 46588] apr_memcache_multgetp memory corruption and incorrect error handling
Date Fri, 20 Feb 2009 10:24:53 GMT

--- Comment #3 from Sami Tolvanen <sami.tolvanen@mywot.com>  2009-02-20 02:24:50 PST
(In reply to comment #2)
> I don't use memcache, so I cannot really comment much on this. Did you ask on
> the list if people agree with this patch?

I didn't. You were the only one who commented on the previous patch, so I
figured there wasn't all that much interest in the memcache code and that I
might just as well leave a bug report for this one.

> PS. I'm pretty sure that the reordering of apr_pollset_destroy and pool cleanup
> is good, but not familiar with the rest at all.

That was the first problem we saw, the two error handling bugs were triggered
only after apr_pollset_* started failing, which is probably why nobody had
noticed them before. The fourth problem with 0-length values is pretty trivial,
I suppose the other users of this code never had empty values in their cache.

Anyway, if it makes any difference, we've been using this patch in production
for a month now without any problems (1-2k requests per second 24/7). The
current code in APR-util 1.3.4 started failing after a couple of seconds under
this load.

Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

To unsubscribe, e-mail: bugs-unsubscribe@apr.apache.org
For additional commands, e-mail: bugs-help@apr.apache.org

View raw message