apr-bugs mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 46588] apr_memcache_multgetp memory corruption and incorrect error handling
Date Fri, 23 Jan 2009 08:38:35 GMT
https://issues.apache.org/bugzilla/show_bug.cgi?id=46588


Sami Tolvanen <sami.tolvanen@mywot.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #23161|0                           |1
        is obsolete|                            |




--- Comment #1 from Sami Tolvanen <sami.tolvanen@mywot.com>  2009-01-23 00:38:33 PST
---
Created an attachment (id=23164)
 --> (https://issues.apache.org/bugzilla/attachment.cgi?id=23164)
Proposed fixes v2

I updated the patch to take care of one more problem we discovered.

4. If one of the requested values has length 0, which is perfectly legitimate,
apr_memcache_multgetp doesn't read the empty line following the VALUE response
from the server. This causes the next get_server_line call to read the empty
line and because the command isn't recognized, all further data from the socket
is discarded. As queries_sent isn't decreased in this case, the poll loop won't
exit until apr_pollset_poll eventually times out.

The patch solves the problem by reading the server response even for 0-length
values.


-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@apr.apache.org
For additional commands, e-mail: bugs-help@apr.apache.org


Mime
View raw message