apr-bugs mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 24325] apr_reslist doesn't work without threads
Date Fri, 25 Jul 2008 08:11:58 GMT
https://issues.apache.org/bugzilla/show_bug.cgi?id=24325





--- Comment #6 from Sönke Tesch <st@kino-fahrplan.de>  2008-07-25 01:11:57 PST ---
> +  #error "apr_reslist doesn't support non-threaded environments"
>
> Existing software that correctly checks APR_HAS_THREADS in the code will fail
> compilation, because it will now error on apr_reslist.h inclusion.

Well, #warning could still be used instead of #error - no harm done and still
some level of exact information. As I wrote, I only came up with this report
because I didn't know that [name your favourite unknown OS here] didn't support
threads, and the compiler messages didn't really point me in the right
direction.

But appart from that: Shouldn't source that checks for APR_HAS_THREADS avoid
#including apr_reslist.h in the first place instead of including but not using?
At least that's what I'd call 100% correct usage of APR_HAS_THREADS. So, if
they don't include, they won't get an error message. 
For those only 99% correct adding a conditional block around #include takes
just a few seconds, and I can assure you that little message would be greatly
appreciated by less experienced developers who have to remotely debug their
stuff with the help of a user who has almost no idea about programming.


-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@apr.apache.org
For additional commands, e-mail: bugs-help@apr.apache.org


Mime
View raw message