apr-bugs mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 44127] - File Extended Attributes Support
Date Sun, 06 Jan 2008 22:17:07 GMT
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=44127>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=44127





------- Additional Comments From davi@apache.org  2008-01-06 14:17 -------
More comments on the implementation:

A pathname based implementation doesn't play well for some situations
when the file is unlinked or when the pathname needs special handling.
I think what you can do is to support both ways:

typedef struct apr_file_xattr_t;

apr_file_xattr_open(apr_file_xattr_t **xattr, const char *pathname, ....)
apr_file_xattr_fdopen(apr_file_xattr_t **xattr, apr_file_t *file, ....)
apr_file_xattr_destroy(apr_file_xattr_t *xattr);

and in the implementation you use which one is most convenient, the file
handle or the pathname, even when the pathname only is used you can keep
the file descriptor open between xattr calls. This is the way most APR
interfaces are implemented and tends to make more sense APR/API wide.

I think you don't need to pass flags/pool to each function, by using the
above interface you can keep the flags inside the apr_file_xattr_t struct.

The way the files are built should be done the other way around, look at
how the atomic files are built. Since you already have the USE_XATTR_*
macros you just need to cover each file if a #if on the macro. This way
all the files are built and dependencies are automatically tracked.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@apr.apache.org
For additional commands, e-mail: bugs-help@apr.apache.org


Mime
View raw message