apr-bugs mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 43035] - Add ability to wrap ssl around pre-existing sockets
Date Sat, 04 Aug 2007 21:01:13 GMT
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=43035>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=43035





------- Additional Comments From nathan.mittler@gmail.com  2007-08-04 14:01 -------
(In reply to comment #2)
> Just some cosmetics:
> 
> why doesn't the declaration of the apr_ssl_socket_create_wrapper function have
> names for it's parameters? The Doxygen comments have the names, but I don't
> think all IDEs parse Doxygen. Having the names in the declaration may help
> programmers with IDEs which can autocomplete and show tooltips with the function
>  signature. 
> 
> return APR_ENOMEM instead of ENOMEM (even though currently they are defined to
> be the same, it's safer/clearer).
> 
> don't return "-1", apr_strerror doesn't understand it and it's ugly, just return
> the error you got in "if (apu_ssl_socket_create(sslSock, asf) != APR_SUCCESS)".
> 
> the coding standard mandates using '_' to separate words in variable and
> function names. "ownSocket => own_socket"?

I was following the conventions used in the files that I was editing.  I can
update my patch, but the changes should probably be made across the board. 
Perhaps there are other files outside of the ssl package that have these issues
as well?


-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@apr.apache.org
For additional commands, e-mail: bugs-help@apr.apache.org


Mime
View raw message