apr-bugs mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 42889] - Thread pooling declaration fix and enhancements
Date Fri, 13 Jul 2007 20:48:50 GMT
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=42889>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=42889





------- Additional Comments From henryjen@ztune.net  2007-07-13 13:48 -------
Nice. :-)

One question: since the total number of tasks processed(tasks_run) is collected
over time and could overflow, would it better to collect in interval? Anyway,
that may not be a big concern.

The code stopping the timeout idle threads is not quite correct:

1. The thread should only be joined when the thread is stopped in idle mode by
trim_idle_thread, i.e, when elt->stop is 1. Otherwise, the thread should be
detached and exit as no one would be there join the thread.

2. The thd_timed_out should be increased for the thread to quit after time out,
ie. when elt->stop == 0. The code seems to have an unintended else with the if
statement.



-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@apr.apache.org
For additional commands, e-mail: bugs-help@apr.apache.org


Mime
View raw message