apr-bugs mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 41119] - apr_pool_cleanup_for_exec must discard I/O buffers
Date Wed, 18 Apr 2007 22:51:35 GMT
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=41119>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=41119





------- Additional Comments From bojan@rexursive.com  2007-04-18 15:51 -------
> Changing it should be as simple as registering a different child_cleanup in
apr_file_open() - a cleanup which doesn't call flush like apr_unix_file_cleanup().

If there is only one possible behaviour of the child cleanup here, then that's a
really easy fix. I wasn't sure if that would be the case, so I went on inventing
hackish ways of having two, probably completely unnecessary :-)

> You can get into a philosophical debate here about whether API is defined by
random comments in headers or by actual implementation behaviour.

I would view this from the "does it make sense" point of view. At present, the
exact same piece of data stored in the buffer gets written into the file twice.
That seems to be the bit that doesn't make sense to me, so changing the
behaviour would be warranted.

But then again, if we historically didn't do this, we should just change the
documentation and let people know that they _must_ flush all buffered files
before calling apr_proc_create(), or they will suffer from this.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@apr.apache.org
For additional commands, e-mail: bugs-help@apr.apache.org


Mime
View raw message