apisix-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #1816: feat: Use monaco editor
Date Wed, 12 May 2021 04:58:37 GMT

juzhiyuan commented on a change in pull request #1816:
URL: https://github.com/apache/apisix-dashboard/pull/1816#discussion_r630724524



##########
File path: web/package.json
##########
@@ -68,6 +67,7 @@
     "js-yaml": "^4.0.0",
     "lodash": "^4.17.11",
     "moment": "^2.25.3",
+    "monaco-editor-webpack-plugin": "^3.0.1",

Review comment:
       This dependency is used to `A plugin to simplify loading the Monaco Editor with webpack.`
Maybe it belongs to `dev-dependencies`?
   
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message