apisix-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [apisix] spacewander commented on a change in pull request #3766: docs: add --server option for the use of luarocks
Date Mon, 15 Mar 2021 01:22:39 GMT

spacewander commented on a change in pull request #3766:
URL: https://github.com/apache/apisix/pull/3766#discussion_r593997301



##########
File path: Makefile
##########
@@ -60,6 +60,7 @@ help: default
 ### deps:             Installation dependencies
 .PHONY: deps
 deps: default
+luarocks install apisix --server https://luarocks.cn

Review comment:
       @stu01509
   I have already told you **many times**.
   
   > See my first comment. "We should wrap the server option in `make deps` ...". We need
to introduce something like `LUAROCKS_SERVER=https://luarocks.cn make deps`.
   
   https://github.com/apache/apisix/pull/3766#discussion_r589118059
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message