Mailing-List: contact dev-help@apex.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@apex.apache.org
MIME-Version: 1.0
In-Reply-To: <765702a0-bf55-582a-c1bd-0ad9da042fb8@gmail.com>
References: <1ea6d41a-1ae6-e9af-8e03-4bc72f136869@gmail.com>
 <CAA7LveFFqFORtDZ-2m6Jx0rR-qCD7RSVTEtDAqy-UGcjuvQzeQ@mail.gmail.com> <765702a0-bf55-582a-c1bd-0ad9da042fb8@gmail.com>
From: Sanjay Pujare <sanjay@datatorrent.com>
Date: Fri, 8 Sep 2017 11:37:01 -0700
Message-ID: <CALPtS-J3L7EMTb6kkOyi5JeYvn8v9+1KfJ-W+VKYZjp-_x4Z1w@mail.gmail.com>
Subject: Re: following committer guideline when merging PR
To: dev@apex.apache.org
Content-Type: multipart/alternative; boundary="001a113cf02ce72d5b0558b1dc7e"
archived-at: Fri, 08 Sep 2017 18:37:09 -0000

--001a113cf02ce72d5b0558b1dc7e
Content-Type: text/plain; charset="UTF-8"

Regarding updating JIRA (item#3) I think it should ideally be the
contributor's responsibility to update the JIRA with all the required
fields and not the committer's.

On Fri, Sep 8, 2017 at 11:25 AM, Vlad Rozov <v.rozov64@gmail.com> wrote:

> item #3. The concern with #661 is with all items that I marked in red in
> my first email.
>
> Thank you,
>
> Vlad
>
> On 9/8/17 10:48, Pramod Immaneni wrote:
>
>> What's your concern with #669. It's a fix for a build issue (which you
>> created) and was approved by two committers. Wasn't getting builds to
>> successful state asap one of your top concerns based on your comments and
>> -1 on #569 on core.
>>
>> On Fri, Sep 8, 2017 at 9:16 AM, Vlad Rozov <v.rozov64@gmail.com> wrote:
>>
>> Committers,
>>>
>>> Please make sure to follow Apex community guideline when merging PR
>>> http://apex.apache.org/contributing.html.
>>>
>>> 1. Ensure that basic requirements for a pull request are met. This
>>>     includes:
>>>       * Sufficient time has passed for others to review
>>>       * PR was suffiently reviewed and comments were addressed.
>>>         Seevoting policy <https://www.apache.org/foundation/voting.html
>>> >.
>>>       * When there are multiple reviewers, wait till other reviewers
>>>         approve, with timeout of 48 hours before merging
>>>       * /If the PR was open for a long time, email dev@ declaring intent
>>>         to merge/
>>>       * Commit messages and PR title need to reference JIRA (pull
>>>         requests will be linked to ticket)
>>>       * /Travis CI and Jenkins pull request build needs to pass/
>>>       * /Ensure tests are added/modified for new features or fixes/
>>>       * Ensure appropriate JavaDoc comments have been added
>>>       * Verify contributions don't depend on incompatible licences
>>>         (seehttps://www.apache.org/legal/resolved.html#category-x)
>>> 2. Use the github/rebase and merge/option or the git command line to
>>>     merge the pull request (see link|view command line options|on the
>>> PR).
>>> 3. /Update JIRA after pushing the changes. Set the////|Fix
>>>     version|////field and resolve the JIRA with proper resolution. *Also
>>>     verify that other fields (type, priority, assignee) are correct*./
>>>
>>>
>>> A couple of recent PR merges (#661, #669) to apex-malhar require a second
>>> look from the committers.
>>>
>>> Thank you,
>>>
>>> Vlad
>>>
>>>
>

--001a113cf02ce72d5b0558b1dc7e--