Mailing-List: contact dev-help@apex.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@apex.apache.org
Subject: Re: Input needed for ApexCli.
To: dev@apex.apache.org
References: <967E9B49-2476-4B06-AA31-449DE4971EDA@datatorrent.com>
 <CAA7LveF7r=w8L9WQpG+Z3P3xKcoWQSSy0TPWWSQgpRtasWBXfQ@mail.gmail.com>
 <CAHvM9d0PGfoqG8_McqXY-qpJd-Jak+d5NbYW078Hy05_xWEP1w@mail.gmail.com>
 <CA+mX7fq_nG9EB4Vp8Jc3N2RTrdCi+a6ZRoN_GgoVePHW=h3yew@mail.gmail.com>
 <CALPtS-JCiZhnfKjA16J1URGMOyeN=Wzc+tTXoWXtjVhhybiSkA@mail.gmail.com>
From: Vlad Rozov <vrozov@apache.org>
Organization: Apache Apex
Message-ID: <ad393093-d6d9-738b-3404-840189b7ec28@apache.org>
Date: Sat, 5 Aug 2017 12:12:15 -0700
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:52.0)
 Gecko/20100101 Thunderbird/52.2.1
MIME-Version: 1.0
In-Reply-To: <CALPtS-JCiZhnfKjA16J1URGMOyeN=Wzc+tTXoWXtjVhhybiSkA@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US
archived-at: Sat, 05 Aug 2017 19:12:22 -0000

I don't see need for the flag either. The output of the command should 
be what applications were stopped/shutdown and which one were not (for 
any reason).

Thank you,

Vlad

On 8/4/17 23:21, Sanjay Pujare wrote:
> +1 for best effort. I don't think a flag to offer alternative behavior is
> of much value.
>
> On Aug 5, 2017 11:31 AM, "AJAY GUPTA" <ajaygit158@gmail.com> wrote:
>
>> It could be useful to have a flag and let user decide the best approach fit
>> for him. We can have the default behaviour as best-effort with support for
>> Validate and fail via flag.
>>
>> Ajay
>>
>> On Sat, 5 Aug 2017 at 8:33 AM, Bhupesh Chawda <bhupesh@datatorrent.com>
>> wrote:
>>
>>> +1 for best effort with warnings.
>>>
>>> ~ Bhupesh
>>>
>>> On Aug 4, 2017 23:46, "Pramod Immaneni" <pramod@datatorrent.com> wrote:
>>>
>>>> I would prefer "Best effort" with warnings for the ones that are
>> invalid.
>>>> On Fri, Aug 4, 2017 at 9:42 AM, Florian Schmidt <
>> florian@datatorrent.com
>>>> wrote:
>>>>
>>>>> Hey everyone,
>>>>>
>>>>> I am currently extending the ApexCli so that the `shutdown-app`
>> command
>>>>> supports the both the appId and the appName as an argument (see
>>>>> https://issues.apache.org/jira/browse/APEXCORE-767 <
>>>>> https://issues.apache.org/jira/browse/APEXCORE-767>)
>>>>>
>>>>> During the review of the pull request, the following discussion came
>>> up:
>>>>> When a user passes multiple appNames / appIds to the shutdown command
>>>>> (e.g. shutdown-app appA appB appC) and e.g. appB does not exists,
>> which
>>>> one
>>>>> of the two approaches do we want to go:
>>>>>
>>>>> "Best effort”: Try to shutdown all those apps where we can find an
>> app
>>> to
>>>>> the provided appName or appId. Print a warning if an app cannot
>> found.
>>>>> “Validate and Fail”: Validate that all apps can be found by the
>>> provided
>>>>> appId / appName. Do not run the command if one of the apps can’t be
>>> found
>>>>> This decision would probably influence the behavior of other CLI
>>> commands
>>>>> in the future as well, so that they all behave in a consistent way.
>>> What
>>>>> are your opinions?
>>>>>
>>>>> Regards
>>>>>
>>>>> Florian
>>>>>
>>>>>
>>>>>
>>>>>