apex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (APEXCORE-775) StramClientUtils.getApexDFSRootDir() incorrectly sets DT_DFS_ROOT_DIR in the configuration object
Date Wed, 09 Aug 2017 20:34:00 GMT

    [ https://issues.apache.org/jira/browse/APEXCORE-775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16120615#comment-16120615
] 

ASF GitHub Bot commented on APEXCORE-775:
-----------------------------------------

sanjaypujare opened a new pull request #569: APEXCORE-775  do not update the conf object in
evalDFSRootDir when called for APEX_APP_DFS_ROOT_DIR
URL: https://github.com/apache/apex-core/pull/569
 
 
   @PramodSSImmaneni  pls review and merge as appropriate
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> StramClientUtils.getApexDFSRootDir() incorrectly sets DT_DFS_ROOT_DIR in the configuration
object
> -------------------------------------------------------------------------------------------------
>
>                 Key: APEXCORE-775
>                 URL: https://issues.apache.org/jira/browse/APEXCORE-775
>             Project: Apache Apex Core
>          Issue Type: Bug
>            Reporter: Sanjay M Pujare
>            Assignee: Sanjay M Pujare
>
> In StramClientUtils.getApexDFSRootDir method there is a call to evalDFSRootDir which
does the following:
> ```
>       if (userShortName != null && dfsRootDir.contains(DT_DFS_USER_NAME)) {
>         dfsRootDir = dfsRootDir.replace(DT_DFS_USER_NAME, userShortName);
>         conf.set(DT_DFS_ROOT_DIR, dfsRootDir);
>       }
> ```
> i.e. it writes in the conf object to property DT_DFS_ROOT_DIR although the caller was
querying APEX_APP_DFS_ROOT_DIR .
> 2 issues with this:
> - When caller is calling getApexDFSRootDir the code has no business touching DT_DFS_ROOT_DIR
> - a single value for APEX_APP_DFS_ROOT_DIR should not be written in the conf object if
the conf object is shared by a multi-user program that is monitoring multiple apps for multiple
users



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message