Mailing-List: contact dev-help@apex.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@apex.apache.org
Date: Thu, 27 Jul 2017 11:28:02 +0000 (UTC)
From: "Sanjay M Pujare (JIRA)" <jira@apache.org>
To: dev@apex.incubator.apache.org
Message-ID: <JIRA.13090491.1501154845000.26391.1501154882891@Atlassian.JIRA>
In-Reply-To: <JIRA.13090491.1501154845000@Atlassian.JIRA>
References: <JIRA.13090491.1501154845000@Atlassian.JIRA> <JIRA.13090491.1501154845421@jira-lw-us.apache.org>
Subject: [jira] [Created] (APEXCORE-771) Refactor the function
 StreamingAppMasterService.execute() for maintainability
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Thu, 27 Jul 2017 11:28:09 -0000

Sanjay M Pujare created APEXCORE-771:
----------------------------------------

             Summary: Refactor the function StreamingAppMasterService.execute() for maintainability
                 Key: APEXCORE-771
                 URL: https://issues.apache.org/jira/browse/APEXCORE-771
             Project: Apache Apex Core
          Issue Type: Improvement
            Reporter: Sanjay M Pujare


PR#535 discussion is the reason for this PR.

Refactoring StreamingAppMasterService.execute() would consist of splitting this code into multiple smaller functions (or even classes) and using mocks to unit test these smaller chunks. For example we can create a class and move all the requested/released container list and count management in this class. This way the code in StreamingAppMasterService.execute() will be manageably small.

Benefits from this refactoring effort are:
- code will be easy to understand and maintain for new members because of multiple small functions or classes
- it will be easy to simulate various corner or error cases related to Yarn behavior using mocks that currently are impossible to simulate
- for every new bug reported we will be able to add unit tests to create a regression test suite.


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)