Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 0E4E4200C66 for ; Sun, 16 Apr 2017 06:26:49 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 01B29160BA9; Sun, 16 Apr 2017 04:26:49 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 46F71160BA0 for ; Sun, 16 Apr 2017 06:26:48 +0200 (CEST) Received: (qmail 21950 invoked by uid 500); 16 Apr 2017 04:26:47 -0000 Mailing-List: contact dev-help@apex.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@apex.apache.org Delivered-To: mailing list dev@apex.apache.org Received: (qmail 21938 invoked by uid 99); 16 Apr 2017 04:26:47 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 16 Apr 2017 04:26:47 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 7C9661A0492 for ; Sun, 16 Apr 2017 04:26:46 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -100.002 X-Spam-Level: X-Spam-Status: No, score=-100.002 tagged_above=-999 required=6.31 tests=[RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id J81rnkdUgEea for ; Sun, 16 Apr 2017 04:26:44 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 7288A5FC4D for ; Sun, 16 Apr 2017 04:26:44 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id C1035E0AB0 for ; Sun, 16 Apr 2017 04:26:43 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 65FAE21B47 for ; Sun, 16 Apr 2017 04:26:42 +0000 (UTC) Date: Sun, 16 Apr 2017 04:26:42 +0000 (UTC) From: "Vlad Rozov (JIRA)" To: dev@apex.incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (APEXCORE-703) Window processing timeout for finished/undeployed container MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Sun, 16 Apr 2017 04:26:49 -0000 [ https://issues.apache.org/jira/browse/APEXCORE-703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15970233#comment-15970233 ] Vlad Rozov commented on APEXCORE-703: ------------------------------------- [~thw] I don't see undeployed operators being removed from the plan immediately and the state of such operators is not updated, so they are still considered to be ACTIVE and are subject to the blocked operators check. Why StreamingContainerManager does not set the state of an operator to INACTIVE when it is added to the list of operators to undeploy? {noformat} case SHUTDOWN: // schedule operator deactivation against the windowId // will be processed once window is committed and all dependent operators completed processing long windowId = oper.stats.currentWindowId.get(); if (ohb.windowStats != null && !ohb.windowStats.isEmpty()) { windowId = ohb.windowStats.get(ohb.windowStats.size() - 1).windowId; } LOG.debug("Operator {} deactivated at window {}", oper, windowId); synchronized (this.shutdownOperators) { Set deactivatedOpers = this.shutdownOperators.get(windowId); if (deactivatedOpers == null) { this.shutdownOperators.put(windowId, deactivatedOpers = new HashSet<>()); } deactivatedOpers.add(oper); } sca.undeployOpers.add(oper.getId()); ---> can we mark operator as inactive here? slowestUpstreamOp.remove(oper); // record operator stop event recordEventAsync(new StramEvent.StopOperatorEvent(oper.getName(), oper.getId(), oper.getContainer().getExternalId())); break; {noformat} > Window processing timeout for finished/undeployed container > ----------------------------------------------------------- > > Key: APEXCORE-703 > URL: https://issues.apache.org/jira/browse/APEXCORE-703 > Project: Apache Apex Core > Issue Type: Bug > Affects Versions: 3.5.0 > Reporter: Daniel Halperin > > Using Apex 3.5.0 with Apache Beam, I have a 10-container pipeline. The first container, id #1, finishes and gets undeployed at 12:41:10 PM. > Then, 60s later (at 12:42:10 PM), Apex decides that container is blocked because no data has been received for 60s, declares failure, and restarts it. > This would seem to be a bug -- shouldn't finished and undeployed operators be deregistered from the timeout logic that is detecting stuck operators? > Log below > {code} > Apr 14, 2017 12:41:10 PM com.datatorrent.stram.engine.StreamingContainer processHeartbeatResponse > INFO: Undeploy request: [1] > Apr 14, 2017 12:41:10 PM com.datatorrent.stram.engine.StreamingContainer undeploy > INFO: Undeploy complete. > Apr 14, 2017 12:42:10 PM com.datatorrent.stram.StreamingContainerManager updateRecoveryCheckpoints > WARNING: Marking operator PTOperator[id=1,name=TextIO.Read/Read] blocked committed window ffffffffffffffff, recovery window ffffffffffffffff, current time 1492198930012, last window id change time 1492198869957, window processing timeout millis 60000 > Apr 14, 2017 12:42:10 PM com.datatorrent.stram.StreamingContainerManager updateCheckpoints > INFO: Blocked operator PTOperator[id=1,name=TextIO.Read/Read] container PTContainer[id=1(container-6),state=ACTIVE] time 60055ms > Apr 14, 2017 12:42:11 PM com.datatorrent.stram.engine.StreamingContainer processHeartbeatResponse > INFO: Received shutdown request > Apr 14, 2017 12:42:11 PM com.datatorrent.stram.StramLocalCluster run > INFO: Container container-6 restart. > Apr 14, 2017 12:42:11 PM com.datatorrent.stram.StreamingContainerManager scheduleContainerRestart > INFO: Initiating recovery for container-6@localhost > Apr 14, 2017 12:42:11 PM com.datatorrent.stram.StreamingContainerManager updateRecoveryCheckpoints > WARNING: Marking operator PTOperator[id=1,name=TextIO.Read/Read] blocked committed window ffffffffffffffff, recovery window ffffffffffffffff, current time 1492198931015, last window id change time 1492198869957, window processing timeout millis 60000 > {code} -- This message was sent by Atlassian JIRA (v6.3.15#6346)