Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 1144E200C2C for ; Fri, 17 Feb 2017 02:52:46 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 10175160B72; Fri, 17 Feb 2017 01:52:46 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 5F30E160B61 for ; Fri, 17 Feb 2017 02:52:45 +0100 (CET) Received: (qmail 35969 invoked by uid 500); 17 Feb 2017 01:52:44 -0000 Mailing-List: contact dev-help@apex.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@apex.apache.org Delivered-To: mailing list dev@apex.apache.org Received: (qmail 35948 invoked by uid 99); 17 Feb 2017 01:52:44 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 17 Feb 2017 01:52:44 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 2CBB91A08D9 for ; Fri, 17 Feb 2017 01:52:44 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -1.199 X-Spam-Level: X-Spam-Status: No, score=-1.199 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, KAM_LAZY_DOMAIN_SECURITY=1, RP_MATCHES_RCVD=-2.999] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id C0tqD80Q1BY9 for ; Fri, 17 Feb 2017 01:52:43 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id BEB215F5D3 for ; Fri, 17 Feb 2017 01:52:42 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id ECD9DE039E for ; Fri, 17 Feb 2017 01:52:41 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id A47382411B for ; Fri, 17 Feb 2017 01:52:41 +0000 (UTC) Date: Fri, 17 Feb 2017 01:52:41 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: dev@apex.incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (APEXCORE-624) Shutdown does not work because of incorrect logic in the AppMaster MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Fri, 17 Feb 2017 01:52:46 -0000 [ https://issues.apache.org/jira/browse/APEXCORE-624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15871040#comment-15871040 ] ASF GitHub Bot commented on APEXCORE-624: ----------------------------------------- Github user asfgit closed the pull request at: https://github.com/apache/apex-core/pull/458 > Shutdown does not work because of incorrect logic in the AppMaster > ------------------------------------------------------------------ > > Key: APEXCORE-624 > URL: https://issues.apache.org/jira/browse/APEXCORE-624 > Project: Apache Apex Core > Issue Type: Bug > Reporter: Sanjay M Pujare > Assignee: Sanjay M Pujare > Priority: Minor > > com.datatorrent.stram.StreamingAppMasterService.execute() calculates numRequestedContainers incorrectly in some cases (e.g. RM container allocation failure) which prevents an application from shutting down when it is requested externally. An example is where we ask RM to remove previous container allocation request (where the count should be decremented but is NOT) and add a new one (where the count should be and IS incremented). Another example is the "alreadyAllocated" case where we release the container and still increment numRequestedContainers which seems wrong. > This bug is showing up in multiple Apex deployments. -- This message was sent by Atlassian JIRA (v6.3.15#6346)