apex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sgolovko <...@git.apache.org>
Subject [GitHub] apex-core pull request #468: SPOI-10695: get-app-package-operators with pare...
Date Wed, 08 Feb 2017 04:03:03 GMT
GitHub user sgolovko opened a pull request:

    https://github.com/apache/apex-core/pull/468

    SPOI-10695: get-app-package-operators with parent option does not work

    There are two apex command line operators that have the option "-parent" (get-app-package-operators
and get-jar-operator-classes). And both of them have the mandatory argument <full name
of the parent class>.
    
    The implementation of the class GetOperatorClassesCommandLineOptions that builds command
line parser options created the descriptor of the option "-parent" without an argument. And
as the result, the argument of the option was ignored and it was moved to the list of the
regular command line parameters.
    
    The bug fix is trivial. It defines the option "-parent" as an option with an argument.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sgolovko/apex-core master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/apex-core/pull/468.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #468
    
----
commit 5220a3b7a4de24357d13c753067efae3c23ab9d5
Author: Sergey Golovko <sergey@datatorrent.com>
Date:   2017-02-08T04:00:02Z

    SPOI-10695: get-app-package-operators with parent option does not work
    
    There are two apex command line operators that have the option "-parent" (get-app-package-operators
and get-jar-operator-classes). And both of them have the mandatory argument <full name
of the parent class>.
    
    The implementation of the class GetOperatorClassesCommandLineOptions that builds command
line parser options created the descriptor of the option "-parent" without an argument. And
as the result, the argument of the option was ignored and it was moved to the list of the
regular command line parameters.
    
    The bug fix is trivial. It defines the option "-parent" as an option with an argument.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message