apex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chaitanya (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (APEXMALHAR-2284) POJOInnerJoinOperatorTest fails in Travis CI
Date Thu, 10 Nov 2016 13:36:58 GMT

    [ https://issues.apache.org/jira/browse/APEXMALHAR-2284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15654057#comment-15654057
] 

Chaitanya commented on APEXMALHAR-2284:
---------------------------------------

I have implemented the Spillable data structures over TimeSlicedBucketedState. But I see a
lot of code duplication in the the new Spillable structures.
We can either check it in for now to unblock the release and keep working on it to improve
it or we wait until we have completed this in the right manner (This will take some time).

Here is the approach I am thinking of to improve the class hierarchy:

* SpillableStateStore to be extended from BucketedState and TimeSlicedBucketedState.
* We then need to implement the following in ManagedSpillableStateStore, ManagedTimeUnifiedStateSpillableStateStore
and InMemSpillableStateStore.
	- void put(bucketId, timeBucketId, key, value)
	- Slice getSync(bucketId, timeBucketId, key)
	- Future<Slice> getAsync(bucketId, timeBucketId, key)

We will need to throw as UnSupportedOperationException from the above methods.
This will help in extending SpillableTimeSliced* (new implementations needed for inner join)
implementations from Spillable* implementations(Existing implementations). 

[~csingh] [~thw] Please suggest if it is okay to check in the current state (correct but with
code duplication)?

> POJOInnerJoinOperatorTest fails in Travis CI
> --------------------------------------------
>
>                 Key: APEXMALHAR-2284
>                 URL: https://issues.apache.org/jira/browse/APEXMALHAR-2284
>             Project: Apache Apex Malhar
>          Issue Type: Bug
>            Reporter: Thomas Weise
>            Assignee: Chaitanya
>            Priority: Blocker
>             Fix For: 3.6.0
>
>
> https://s3.amazonaws.com/archive.travis-ci.org/jobs/166322754/log.txt
> {code}
> Failed tests: 
>   POJOInnerJoinOperatorTest.testEmitMultipleTuplesFromStream2:337 Number of tuple emitted
 expected:<2> but was:<4>
>   POJOInnerJoinOperatorTest.testInnerJoinOperator:184 Number of tuple emitted  expected:<1>
but was:<2>
>   POJOInnerJoinOperatorTest.testMultipleValues:236 Number of tuple emitted  expected:<2>
but was:<3>
>   POJOInnerJoinOperatorTest.testUpdateStream1Values:292 Number of tuple emitted  expected:<1>
but was:<2>
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message