apex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "David Yan (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (APEXCORE-548) ApexCLI does not correctly detect running applications with the same name at launch time
Date Wed, 05 Oct 2016 21:33:20 GMT

    [ https://issues.apache.org/jira/browse/APEXCORE-548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15550007#comment-15550007
] 

David Yan commented on APEXCORE-548:
------------------------------------

The problem is that ApexCli is using the AppFactory.getName() method to get the name of the
application to be launched. AppFactory.getName() returns the fully qualified class name of
the Application class instead of the one given in the ApplicationAnnotation.

To get the name of an unlaunched application, In the AppFactory interface, there is getName()
and getDisplayName(), and then there is this getAppAlias() in LogicalPlanConfiguration. 

For java based applications, the correct way to get the intended name is calling the getAppAlias
method, but for others, getName() on the AppFactory. I can fix this bug by doing instanceof
but it looks like things can be done better.

Seeking feedback from [~thw], [~pramod.immaneni], and [~vrozov].

> ApexCLI does not correctly detect running applications with the same name at launch time
> ----------------------------------------------------------------------------------------
>
>                 Key: APEXCORE-548
>                 URL: https://issues.apache.org/jira/browse/APEXCORE-548
>             Project: Apache Apex Core
>          Issue Type: Bug
>            Reporter: David Yan
>            Assignee: David Yan
>
> ApexCli is incorrectly using the fully qualified class name of the Application class
instead of the name given in the ApplicationAnnotation when trying to make sure no running
application bears the same name.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message