apex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chris Lambertus (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (APEXMALHAR-1859) Integrate checkstyle with Malhar
Date Sat, 08 Oct 2016 04:15:20 GMT

    [ https://issues.apache.org/jira/browse/APEXMALHAR-1859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15154762#comment-15154762
] 

Chris Lambertus edited comment on APEXMALHAR-1859 at 10/8/16 4:14 AM:
----------------------------------------------------------------------

[~thomas.weise@gmail.com] [~pramod.immaneni]

The main problem in my opinion is that Apex module is a parent of Malhar module.  What is
the reason for it?
I guess if it was to inherit plugin but it causes some problems.

semver plugin configuration is redeclared in malhar and it was suggested that checkstyle should
be re-declared as well. So I think we should not make apex a parent of malhar. It makes debugging
difficult with plugin related issues - finding out which configuration is being applied, is
it coming from the parent or is it re-declared.

Since Malhar inherits checkstyle config from Apex and it is a submodule, violations needed
to be specified in the main pom of Malhar. 


was (Author: csingh):
[~thomas.weise@googlemail.com] [~pramod.immaneni]

The main problem in my opinion is that Apex module is a parent of Malhar module.  What is
the reason for it?
I guess if it was to inherit plugin but it causes some problems.

semver plugin configuration is redeclared in malhar and it was suggested that checkstyle should
be re-declared as well. So I think we should not make apex a parent of malhar. It makes debugging
difficult with plugin related issues - finding out which configuration is being applied, is
it coming from the parent or is it re-declared.

Since Malhar inherits checkstyle config from Apex and it is a submodule, violations needed
to be specified in the main pom of Malhar. 

> Integrate checkstyle with Malhar
> --------------------------------
>
>                 Key: APEXMALHAR-1859
>                 URL: https://issues.apache.org/jira/browse/APEXMALHAR-1859
>             Project: Apache Apex Malhar
>          Issue Type: Task
>            Reporter: Chandni Singh
>            Assignee: Chandni Singh
>             Fix For: 3.4.0
>
>
> Checkstyle has been integrated with Apex. Need to integrate it with Malhar.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message