apex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tushargosavi <...@git.apache.org>
Subject [GitHub] apex-core pull request #387: APEXCORE-525 fail validation if statefull strea...
Date Mon, 12 Sep 2016 06:50:50 GMT
GitHub user tushargosavi opened a pull request:

    https://github.com/apache/apex-core/pull/387

    APEXCORE-525 fail validation if statefull streamcodec does not implement newInstance method.

    If user implements a streamcodec extending DefaultStatefulStreamCodec they need to also
remember to implement newInstance method as platform use object returned by newInstance as
codec. If use forget to override newInstance then  platform keep on using default codec without
any warning to user and
    such error are caught very late mostly resulting incorrect data distribution and incorrect
result at final
    operator.
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tushargosavi/incubator-apex-core APEXCORE-525

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/apex-core/pull/387.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #387
    
----
commit 8ab11fae86d608d5fb4a3e06153cee056b4cb5d5
Author: Tushar R. Gosavi <tushar@apache.org>
Date:   2016-09-12T06:43:06Z

    APEXCORE-525: fail validation if statefull streamcodec does not
    implement newInstance method.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message