Mailing-List: contact dev-help@apex.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@apex.apache.org
From: davidyan74 <git@git.apache.org>
To: dev@apex.incubator.apache.org
Reply-To: dev@apex.incubator.apache.org
References: <git-pr-360-apex-core@git.apache.org>
In-Reply-To: <git-pr-360-apex-core@git.apache.org>
Subject: [GitHub] apex-core pull request #360: APEXCORE-495 supporting apps in config package.
Content-Type: text/plain
Message-Id: <20160804190200.6BE2FE0A7D@git1-us-west.apache.org>
Date: Thu,  4 Aug 2016 19:02:00 +0000 (UTC)
archived-at: Thu, 04 Aug 2016 19:02:06 -0000

Github user davidyan74 commented on a diff in the pull request:

    https://github.com/apache/apex-core/pull/360#discussion_r73583092
  
    --- Diff: engine/src/test/java/com/datatorrent/stram/cli/ApexCliTest.java ---
    @@ -53,16 +56,16 @@
       private static File configFile;
     
     
    -  private static AppPackage ap;
    -  private static ConfigPackage cp;
    -  static TemporaryFolder testFolder = new TemporaryFolder();
    -  static ApexCli cli = new ApexCli();
    +  private AppPackage ap;
    +  private ConfigPackage cp;
    +  TemporaryFolder testFolder = new TemporaryFolder();
    +  ApexCli cli = new ApexCli();
     
    -  static Map<String, String> env = new HashMap<String, String>();
    -  static String userHome;
    +  Map<String, String> env = new HashMap<String, String>();
    +  String userHome;
     
    -  @BeforeClass
    -  public static void starting()
    +  @Before
    +  public void starting()
    --- End diff --
    
    Can you explain why this change is needed?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---