Return-Path: <dev-return-14363-archive-asf-public=cust-asf.ponee.io@apex.apache.org>
X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io
Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
	by cust-asf2.ponee.io (Postfix) with ESMTP id 831AE200B49
	for <archive-asf-public-internal@cust-asf2.ponee.io>; Wed,  3 Aug 2016 13:20:40 +0200 (CEST)
Received: by cust-asf.ponee.io (Postfix)
	id 8199E160A86; Wed,  3 Aug 2016 11:20:40 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id C5F76160A64
	for <archive-asf-public@cust-asf.ponee.io>; Wed,  3 Aug 2016 13:20:39 +0200 (CEST)
Received: (qmail 55141 invoked by uid 500); 3 Aug 2016 11:20:38 -0000
Mailing-List: contact dev-help@apex.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@apex.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@apex.apache.org>
List-Post: <mailto:dev@apex.apache.org>
List-Id: <dev.apex.apache.org>
Reply-To: dev@apex.apache.org
Delivered-To: mailing list dev@apex.apache.org
Received: (qmail 55130 invoked by uid 99); 3 Aug 2016 11:20:38 -0000
Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 03 Aug 2016 11:20:38 +0000
Received: from localhost (localhost [127.0.0.1])
	by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 45A371803EA
	for <dev@apex.apache.org>; Wed,  3 Aug 2016 11:20:38 +0000 (UTC)
X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org
X-Spam-Flag: NO
X-Spam-Score: -5.446
X-Spam-Level: 
X-Spam-Status: No, score=-5.446 tagged_above=-999 required=6.31
	tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5,
	RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01,
	RP_MATCHES_RCVD=-1.426] autolearn=disabled
Received: from mx2-lw-us.apache.org ([10.40.0.8])
	by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024)
	with ESMTP id ZN37N4R_TvAo for <dev@apex.apache.org>;
	Wed,  3 Aug 2016 11:20:37 +0000 (UTC)
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by mx2-lw-us.apache.org (ASF Mail Server at mx2-lw-us.apache.org) with SMTP id C1CA55F23C
	for <dev@apex.incubator.apache.org>; Wed,  3 Aug 2016 11:20:36 +0000 (UTC)
Received: (qmail 55059 invoked by uid 99); 3 Aug 2016 11:20:36 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 03 Aug 2016 11:20:36 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33)
	id 1F3B6E3839; Wed,  3 Aug 2016 11:20:36 +0000 (UTC)
From: bhupeshchawda <git@git.apache.org>
To: dev@apex.incubator.apache.org
Reply-To: dev@apex.incubator.apache.org
References: <git-pr-358-apex-malhar@git.apache.org>
In-Reply-To: <git-pr-358-apex-malhar@git.apache.org>
Subject: [GitHub] apex-malhar pull request #358: [review only]APEXMALHAR-2172: Updates to JDBC...
Content-Type: text/plain
Message-Id: <20160803112036.1F3B6E3839@git1-us-west.apache.org>
Date: Wed,  3 Aug 2016 11:20:36 +0000 (UTC)
archived-at: Wed, 03 Aug 2016 11:20:40 -0000

Github user bhupeshchawda commented on a diff in the pull request:

    https://github.com/apache/apex-malhar/pull/358#discussion_r73321098
  
    --- Diff: library/src/main/java/com/datatorrent/lib/db/jdbc/AbstractJdbcPollInputOperator.java ---
    @@ -80,201 +93,48 @@
      * @tags database, sql, jdbc, partitionable,exactlyOnce
      */
     @Evolving
    -public abstract class AbstractJdbcPollInputOperator<T> extends AbstractStoreInputOperator<T, JdbcStore>
    -    implements ActivationListener<Context>, IdleTimeHandler, Partitioner<AbstractJdbcPollInputOperator<T>>
    +public abstract class AbstractJdbcPollInputOperator<T> extends AbstractStoreInputOperator<T, JdbcStore> implements
    +    ActivationListener<OperatorContext>, IdleTimeHandler, Partitioner<AbstractJdbcPollInputOperator<T>>
     {
    +  private static int DEFAULT_QUEUE_CAPACITY = 4 * 1024 * 1024;
    +  private static int DEFAULT_POLL_INTERVAL = 10 * 1000;
    +  private static int DEFAULT_FETCH_SIZE = 20000;
       /**
        * poll interval in milliseconds
        */
    -  private static int pollInterval = 10000;
    +  private int pollInterval = DEFAULT_POLL_INTERVAL;
    +  private int queueCapacity = DEFAULT_QUEUE_CAPACITY;
    +  private int fetchSize = DEFAULT_FETCH_SIZE;
     
       @Min(1)
       private int partitionCount = 1;
       protected transient int operatorId;
    -  protected transient boolean isReplayed;
    -  protected transient boolean isPollable;
    +  protected boolean isPollerPartition;
       protected int batchSize;
    -  protected static int fetchSize = 20000;
    +
       /**
        * Map of windowId to <lower bound,upper bound> of the range key
        */
    -  protected transient MutablePair<String, String> currentWindowRecoveryState;
    +  protected transient MutablePair<Integer, Integer> currentWindowRecoveryState;
    +  private transient DSLContext create;
     
    -  /**
    -   * size of the emit queue used to hold polled records before emit
    -   */
    -  private static int queueCapacity = 4 * 1024 * 1024;
       private transient volatile boolean execute;
       private transient AtomicReference<Throwable> cause;
    +  private String tableName;
    +  private String columnsExpression;
    +  private String whereCondition = null;
    +  private String key;
       protected transient int spinMillis;
    -  private transient OperatorContext context;
    -  protected String tableName;
    -  protected String key;
       protected long currentWindowId;
    -  protected KeyValPair<String, String> rangeQueryPair;
    -  protected String lower;
    -  protected String upper;
    -  protected boolean recovered;
    -  protected boolean isPolled;
    -  protected String whereCondition = null;
    -  protected String previousUpperBound;
    -  protected String highestPolled;
    -  private static final String user = "";
    -  private static final String password = "";
    -  /**
    -   * thread to poll database
    -   */
    -  private transient Thread dbPoller;
    -  protected transient ArrayBlockingQueue<List<T>> emitQueue;
    +  protected KeyValPair<Integer, Integer> rangeQueryPair;
    +  protected Integer lower;
    +  protected transient boolean isPolled;
    +  protected transient Integer lastPolledBound;
    +  protected transient Integer lastEmittedRecord;
    +  protected transient ScheduledExecutorService scanService;
    +  protected transient LinkedBlockingDeque<T> emitQueue;
       protected transient PreparedStatement ps;
       protected WindowDataManager windowManager;
    --- End diff --
    
    Perhaps a lot of the above variables can be private. Can you check which ones can be made private?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---