Mailing-List: contact dev-help@apex.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@apex.apache.org
From: davidyan74 <git@git.apache.org>
To: dev@apex.incubator.apache.org
Reply-To: dev@apex.incubator.apache.org
References: <git-pr-324-apex-malhar@git.apache.org>
In-Reply-To: <git-pr-324-apex-malhar@git.apache.org>
Subject: [GitHub] apex-malhar pull request #324: Spillable Datastructures PR for review only
Content-Type: text/plain
Message-Id: <20160801234942.1FFCDE058E@git1-us-west.apache.org>
Date: Mon,  1 Aug 2016 23:49:42 +0000 (UTC)
archived-at: Mon, 01 Aug 2016 23:49:47 -0000

Github user davidyan74 commented on a diff in the pull request:

    https://github.com/apache/apex-malhar/pull/324#discussion_r73073791
  
    --- Diff: library/src/main/java/org/apache/apex/malhar/lib/state/spillable/SpillableByteArrayListMultimapImpl.java ---
    @@ -0,0 +1,292 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *   http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing,
    + * software distributed under the License is distributed on an
    + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    + * KIND, either express or implied.  See the License for the
    + * specific language governing permissions and limitations
    + * under the License.
    + */
    +package org.apache.apex.malhar.lib.state.spillable;
    +
    +import java.util.Collection;
    +import java.util.List;
    +import java.util.Map;
    +import java.util.Set;
    +
    +import javax.annotation.Nullable;
    +import javax.validation.constraints.NotNull;
    +
    +import org.apache.apex.malhar.lib.utils.serde.PassThruByteArraySliceSerde;
    +import org.apache.apex.malhar.lib.utils.serde.Serde;
    +import org.apache.apex.malhar.lib.utils.serde.SerdeIntSlice;
    +import org.apache.apex.malhar.lib.utils.serde.SliceUtils;
    +
    +import com.esotericsoftware.kryo.DefaultSerializer;
    +import com.esotericsoftware.kryo.serializers.FieldSerializer;
    +import com.google.common.base.Preconditions;
    +import com.google.common.collect.Multimap;
    +import com.google.common.collect.Multiset;
    +
    +import com.datatorrent.api.Context;
    +import com.datatorrent.netlet.util.Slice;
    +
    +/**
    + * Created by tfarkas on 6/12/16.
    + */
    +@DefaultSerializer(FieldSerializer.class)
    +public class SpillableByteArrayListMultimapImpl<K, V> implements Spillable.SpillableByteArrayListMultimap<K, V>,
    +    Spillable.SpillableComponent
    +{
    +  public static final int DEFAULT_BATCH_SIZE = 1000;
    +  public static final byte[] SIZE_KEY_SUFFIX = new byte[]{(byte)0, (byte)0, (byte)0};
    +
    +  private transient WindowBoundedMapCache<K, SpillableArrayListImpl<V>> cache = new WindowBoundedMapCache<>();
    +  private transient boolean isRunning = false;
    +  private transient boolean isInWindow = false;
    +
    +  private int batchSize = DEFAULT_BATCH_SIZE;
    +  @NotNull
    +  private SpillableByteMapImpl<byte[], Integer> map;
    +  private SpillableStateStore store;
    +  private byte[] identifier;
    +  private long bucket;
    +  private Serde<K, Slice> serdeKey;
    +  private Serde<V, Slice> serdeValue;
    +
    +  private SpillableByteArrayListMultimapImpl()
    +  {
    +    // for kryo
    +  }
    +
    +  public SpillableByteArrayListMultimapImpl(SpillableStateStore store, byte[] identifier, long bucket,
    +      Serde<K, Slice> serdeKey,
    +      Serde<V, Slice> serdeValue)
    +  {
    +    this.store = Preconditions.checkNotNull(store);
    +    this.identifier = Preconditions.checkNotNull(identifier);
    +    this.bucket = bucket;
    +    this.serdeKey = Preconditions.checkNotNull(serdeKey);
    +    this.serdeValue = Preconditions.checkNotNull(serdeValue);
    +
    +    map = new SpillableByteMapImpl(store, identifier, bucket, new PassThruByteArraySliceSerde(), new SerdeIntSlice());
    +  }
    +
    +  public SpillableStateStore getStore()
    +  {
    +    return store;
    +  }
    +
    +  @Override
    +  public List<V> get(@Nullable K key)
    +  {
    +    return getHelper(key);
    +  }
    +
    +  private SpillableArrayListImpl<V> getHelper(@Nullable K key)
    +  {
    +    SpillableArrayListImpl<V> spillableArrayList = cache.get(key);
    +
    +    if (spillableArrayList == null) {
    +      Slice keySlice = serdeKey.serialize(key);
    +      Integer size = map.get(SliceUtils.concatenate(keySlice, SIZE_KEY_SUFFIX).toByteArray());
    --- End diff --
    
    I see that you removed the identifier as part of the key that stores the size. Would this create a conflict with different identifiers?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---