Mailing-List: contact dev-help@apex.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@apex.apache.org
From: chandnisingh <git@git.apache.org>
To: dev@apex.incubator.apache.org
Reply-To: dev@apex.incubator.apache.org
References: <git-pr-324-apex-malhar@git.apache.org>
In-Reply-To: <git-pr-324-apex-malhar@git.apache.org>
Subject: [GitHub] apex-malhar pull request #324: Spillable Datastructures PR for review only
Content-Type: text/plain
Message-Id: <20160801202305.0C1C9E058E@git1-us-west.apache.org>
Date: Mon,  1 Aug 2016 20:23:05 +0000 (UTC)
archived-at: Mon, 01 Aug 2016 20:23:09 -0000

Github user chandnisingh commented on a diff in the pull request:

    https://github.com/apache/apex-malhar/pull/324#discussion_r73046073
  
    --- Diff: library/src/main/java/org/apache/apex/malhar/lib/state/spillable/SpillableIdentifierGenerator.java ---
    @@ -0,0 +1,37 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *   http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing,
    + * software distributed under the License is distributed on an
    + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    + * KIND, either express or implied.  See the License for the
    + * specific language governing permissions and limitations
    + * under the License.
    + */
    +package org.apache.apex.malhar.lib.state.spillable;
    +
    +/**
    + * Classes implementing this interface can be used as generators for identifiers for Spillable data structures.
    + */
    +public interface SpillableIdentifierGenerator
    +{
    +  /**
    +   * Generators the next valid identifier for a Spillable data structure.
    +   * @return A byte array which represents the next valid identifier for a Spillable data structure.
    +   */
    +  public byte[] next();
    +
    +  /**
    +   * Registers the given identifier with this {@link SpillableIdentifierGenerator}.
    +   * @param identifier The identifier to register with this {@link SpillableIdentifierGenerator}.
    +   */
    +  public void register(byte[] identifier);
    --- End diff --
    
    nit: public is redundant.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---