apex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (APEXMALHAR-2172) Update JDBC poll input operator to fix issues
Date Tue, 09 Aug 2016 06:50:20 GMT

    [ https://issues.apache.org/jira/browse/APEXMALHAR-2172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15413051#comment-15413051
] 

ASF GitHub Bot commented on APEXMALHAR-2172:
--------------------------------------------

Github user bhupeshchawda commented on a diff in the pull request:

    https://github.com/apache/apex-malhar/pull/358#discussion_r74005794
  
    --- Diff: library/src/main/java/com/datatorrent/lib/db/jdbc/JdbcPollInputOperator.java
---
    @@ -18,214 +18,75 @@
      */
     package com.datatorrent.lib.db.jdbc;
     
    -import java.sql.PreparedStatement;
     import java.sql.ResultSet;
     import java.sql.SQLException;
     import java.util.ArrayList;
    -import java.util.List;
    -
    -import org.slf4j.Logger;
    -import org.slf4j.LoggerFactory;
     
     import org.apache.hadoop.classification.InterfaceStability.Evolving;
     
     import com.google.common.collect.Lists;
     
     import com.datatorrent.api.Context.OperatorContext;
    -import com.datatorrent.api.annotation.OperatorAnnotation;
    +import com.datatorrent.api.DefaultOutputPort;
    +import com.datatorrent.api.annotation.OutputPortFieldAnnotation;
     
     /**
    - * A concrete implementation for {@link AbstractJdbcPollInputOperator}} for
    + * A concrete implementation for {@link AbstractJdbcPollInputOperator} for
      * consuming data from MySQL using JDBC interface <br>
    --- End diff --
    
    Can we remove explicit mention for MySQL? I think it is generic as of now..


> Update JDBC poll input operator to fix issues
> ---------------------------------------------
>
>                 Key: APEXMALHAR-2172
>                 URL: https://issues.apache.org/jira/browse/APEXMALHAR-2172
>             Project: Apache Apex Malhar
>          Issue Type: Improvement
>            Reporter: Priyanka Gugale
>            Assignee: Priyanka Gugale
>
> Update JDBCPollInputOperator to:
> 1. Fix small bugs
> 2. Use jooq query dsl library to construct sql queries
> 3. Make code more readable
> 4. Use row counts rather than key column values to partition reads



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message