apex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (APEXMALHAR-2172) Update JDBC poll input operator to fix issues
Date Mon, 08 Aug 2016 09:09:20 GMT

    [ https://issues.apache.org/jira/browse/APEXMALHAR-2172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15411548#comment-15411548
] 

ASF GitHub Bot commented on APEXMALHAR-2172:
--------------------------------------------

Github user DT-Priyanka commented on a diff in the pull request:

    https://github.com/apache/apex-malhar/pull/358#discussion_r73843385
  
    --- Diff: library/src/main/java/com/datatorrent/lib/db/jdbc/AbstractJdbcPollInputOperator.java
---
    @@ -80,201 +91,45 @@
      * @tags database, sql, jdbc, partitionable,exactlyOnce
      */
     @Evolving
    -public abstract class AbstractJdbcPollInputOperator<T> extends AbstractStoreInputOperator<T,
JdbcStore>
    -    implements ActivationListener<Context>, IdleTimeHandler, Partitioner<AbstractJdbcPollInputOperator<T>>
    +public abstract class AbstractJdbcPollInputOperator<T> extends AbstractStoreInputOperator<T,
JdbcStore> implements
    +    ActivationListener<OperatorContext>, Partitioner<AbstractJdbcPollInputOperator<T>>
     {
    -  /**
    -   * poll interval in milliseconds
    -   */
    -  private static int pollInterval = 10000;
    +  private static int DEFAULT_QUEUE_CAPACITY = 4 * 1024 * 1024;
    --- End diff --
    
    changing size to 4k


> Update JDBC poll input operator to fix issues
> ---------------------------------------------
>
>                 Key: APEXMALHAR-2172
>                 URL: https://issues.apache.org/jira/browse/APEXMALHAR-2172
>             Project: Apache Apex Malhar
>          Issue Type: Improvement
>            Reporter: Priyanka Gugale
>            Assignee: Priyanka Gugale
>
> Update JDBCPollInputOperator to:
> 1. Fix small bugs
> 2. Use jooq query dsl library to construct sql queries
> 3. Make code more readable
> 4. Use row counts rather than key column values to partition reads



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message