apex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (APEXCORE-495) Enhancing the configuration package to store apps
Date Thu, 04 Aug 2016 18:58:20 GMT

    [ https://issues.apache.org/jira/browse/APEXCORE-495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15408328#comment-15408328
] 

ASF GitHub Bot commented on APEXCORE-495:
-----------------------------------------

Github user davidyan74 commented on a diff in the pull request:

    https://github.com/apache/apex-core/pull/360#discussion_r73582496
  
    --- Diff: engine/src/test/java/com/datatorrent/stram/cli/ApexCliTest.java ---
    @@ -126,10 +130,14 @@ public void testLaunchAppPackagePropertyPrecedence() throws Exception
       @Test
       public void testLaunchAppPackageParametersWithConfigPackage() throws Exception
       {
    -    ApexCli.LaunchCommandLineInfo commandLineInfo = ApexCli
    -        .getLaunchCommandLineInfo(new String[]{"-exactMatch", "-conf", configFile.getAbsolutePath(),
appFile.getAbsolutePath(), "MyFirstApplication"});
    +    ApexCli.LaunchCommandLineInfo commandLineInfo =
    +        getLaunchCommandLineInfo(new String[]{"-exactMatch", "-conf", configFile.getAbsolutePath(),
appFile.getAbsolutePath(), "MyFirstApplication"});
    +
    +    commandLineInfo.args = new String[1];
    +    commandLineInfo.args[0] = "MyFirstApplication";
    --- End diff --
    
    Please use the notation `new String[]{ "item1", "item2", ... }` instead of doing element
assignment like this.


> Enhancing the configuration package to store apps
> -------------------------------------------------
>
>                 Key: APEXCORE-495
>                 URL: https://issues.apache.org/jira/browse/APEXCORE-495
>             Project: Apache Apex Core
>          Issue Type: Improvement
>            Reporter: Sandesh
>            Assignee: Sandesh
>
> Apex supports configuration package, separates application package from the actual configuration.
(http://docs.datatorrent.com/configuration_packages/)
> We want to enhance the configuration package by adding support to "add Apps" (json format).

> UseCase: Multiple users sharing the same app package, but have a different view of the
golden copy of the app package.
> Note: This feature is requested by an Apex user.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message