apex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (APEXMALHAR-2156) JMS Input operator enhancements
Date Sat, 06 Aug 2016 10:58:20 GMT

    [ https://issues.apache.org/jira/browse/APEXMALHAR-2156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15410589#comment-15410589
] 

ASF GitHub Bot commented on APEXMALHAR-2156:
--------------------------------------------

Github user PramodSSImmaneni commented on a diff in the pull request:

    https://github.com/apache/apex-malhar/pull/347#discussion_r73784565
  
    --- Diff: library/src/main/java/com/datatorrent/lib/io/jms/JMSBase.java ---
    @@ -129,12 +173,20 @@ public void setConnectionFactoryClass(String connectionFactoryClass)
        */
       public Map<String, String> getConnectionFactoryProperties()
       {
    -    return connectionFactoryProperties;
    +    if (connectionFactoryBuilder instanceof DefaultConnectionFactoryBuilder) {
    --- End diff --
    
    On further thought about the serialization aspects and the extra objects, it would create,
suggest having the connectionFactoryBuilder null by default and creating it in the helper
method. So if connectionFactoryBuilder is null or not instance of DefaultConnectionFactoryBuilder
set it to a new DefaultConnectionFactoryBuilder. If someone sets a different factory builder
then an extra default builder will not be used.


> JMS Input operator enhancements
> -------------------------------
>
>                 Key: APEXMALHAR-2156
>                 URL: https://issues.apache.org/jira/browse/APEXMALHAR-2156
>             Project: Apache Apex Malhar
>          Issue Type: Improvement
>            Reporter: Sanjay M Pujare
>            Assignee: Sanjay M Pujare
>   Original Estimate: 672h
>  Remaining Estimate: 672h
>
> This is described in https://drive.google.com/open?id=1gapzjxTiePP0VwaOrc-FWfw4xNK6bcIuxkNkGKoZAiA



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message