apex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (APEXCORE-448) Make operator name available in OperatorContext
Date Thu, 04 Aug 2016 01:22:20 GMT

    [ https://issues.apache.org/jira/browse/APEXCORE-448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15406951#comment-15406951
] 

ASF GitHub Bot commented on APEXCORE-448:
-----------------------------------------

Github user vrozov commented on a diff in the pull request:

    https://github.com/apache/apex-core/pull/364#discussion_r73449937
  
    --- Diff: engine/src/main/java/com/datatorrent/stram/engine/StreamingContainer.java ---
    @@ -902,14 +902,14 @@ private void deployNodes(List<OperatorDeployInfo> nodeList)
throws IOException
     
           Context parentContext;
           if (ndi instanceof UnifierDeployInfo) {
    -        OperatorContext unifiedOperatorContext = new OperatorContext(0, ((UnifierDeployInfo)ndi).operatorAttributes,
containerContext);
    +        OperatorContext unifiedOperatorContext = new OperatorContext(ndi, containerContext);
             parentContext = new PortContext(ndi.inputs.get(0).contextAttributes, unifiedOperatorContext);
             massageUnifierDeployInfo(ndi);
           } else {
             parentContext = containerContext;
           }
     
    -      OperatorContext ctx = new OperatorContext(ndi.id, ndi.contextAttributes, parentContext);
    +      OperatorContext ctx = new OperatorContext(ndi, parentContext);
    --- End diff --
    
    @chandnisingh Here `ndi` may also be an instance of `UnifierDeployInfo` in which case,
the new code will use `ndi.operatorAttribute` while the old code was using `ndi.contextAttributes`.
It sounds that currently only `id` and `name` can be copied from OperatorDeployInfo to OperatorContext,
while attributes must be passed in the constructor. 


> Make operator name available in OperatorContext
> -----------------------------------------------
>
>                 Key: APEXCORE-448
>                 URL: https://issues.apache.org/jira/browse/APEXCORE-448
>             Project: Apache Apex Core
>          Issue Type: Improvement
>            Reporter: Chandni Singh
>            Assignee: Chandni Singh
>
> Need name of the logical operator in the OperatorContext which can be used by WindowDataManager
to create a unique path per logical operator .



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message