apex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (APEXCORE-448) Make operator name available in OperatorContext
Date Wed, 03 Aug 2016 23:09:20 GMT

    [ https://issues.apache.org/jira/browse/APEXCORE-448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15406786#comment-15406786
] 

ASF GitHub Bot commented on APEXCORE-448:
-----------------------------------------

Github user vrozov commented on a diff in the pull request:

    https://github.com/apache/apex-core/pull/364#discussion_r73437878
  
    --- Diff: engine/src/main/java/com/datatorrent/stram/engine/OperatorContext.java ---
    @@ -84,12 +87,13 @@ public void setIdleTimeout(long idleTimeout)
        * @param attributes the value of attributes
        * @param parentContext
        */
    -  public OperatorContext(int id, AttributeMap attributes, Context parentContext)
    +  public OperatorContext(int id, String operatorName, AttributeMap attributes, Context
parentContext)
       {
         super(attributes, parentContext);
         this.lastProcessedWindowId = Stateless.WINDOW_ID;
         this.id = id;
         this.stateless = super.getValue(OperatorContext.STATELESS);
    +    this.operatorName = Preconditions.checkNotNull(operatorName, "operator name");
    --- End diff --
    
    Check for OperatorDeployInfo not null is optional as it will be necessary to dereference
OperatorDeployInfo.id and OperatorDeployInfo.name in the OperatorContext constructor, so NullPointerException
will be raised anyway. Annotating OperatorDeployInfo parameter as `@NotNull` is good, but
we don't follow this practice in other places.


> Make operator name available in OperatorContext
> -----------------------------------------------
>
>                 Key: APEXCORE-448
>                 URL: https://issues.apache.org/jira/browse/APEXCORE-448
>             Project: Apache Apex Core
>          Issue Type: Improvement
>            Reporter: Chandni Singh
>            Assignee: Chandni Singh
>
> Need name of the logical operator in the OperatorContext which can be used by WindowDataManager
to create a unique path per logical operator .



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message